Improve error messaging for creating a Deployment that will violate quotas with high max-in-flight

Fix Rubocop error

Author: nookala

app/actions/deployment_create.rb

@@ -90,11 +90,12 @@ def handle_deployment_create_error(e, app)
         space_quota_errors = [:space_quota_exceeded.to_s, :space_app_instance_limit_exceeded.to_s]
         org_quota_errors = [:quota_exceeded.to_s, :app_instance_limit_exceeded.to_s]
         if space_quota_errors.any? { |substring| e.message.include?(substring) }
-          error_msg = " for space #{app.space.name}. This space's quota may not be large enough to support rolling deployments or your configured max-in-flight."
-          error = DeploymentCreate::Error.new(e.message + error_msg)
+          space_error_msg = " for space #{app.space.name}. This space's quota may not be large enough to support rolling deployments or your configured max-in-flight."
+          error = DeploymentCreate::Error.new(e.message + space_error_msg)
         elsif org_quota_errors.any? { |substring| e.message.include?(substring) }
-          error_msg = " for organization #{app.organization.name}. This organization's quota may not be large enough to support rolling deployments or your configured max-in-flight."
-          error = DeploymentCreate::Error.new(e.message + error_msg)
+          org_error_msg_1 = " for organization #{app.organization.name}. "
+          org_error_msg_2 = "This organization's quota may not be large enough to support rolling deployments or your configured max-in-flight."
+          error = DeploymentCreate::Error.new(e.message + org_error_msg_1 + org_error_msg_2)
         else
           error = DeploymentCreate::Error.new(e.message)
         end