Skip to content

Commit b2fe6d1

Browse files
committed
lock on build is not needed and unique constraint violation can not happen
1 parent 47e6661 commit b2fe6d1

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

app/actions/droplet_create.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,6 @@ def create_docker_droplet(build)
5151

5252
def find_or_create_buildpack_droplet(build)
5353
DropletModel.db.transaction do
54-
BuildModel.where(id: build.id).for_update.first or
55-
raise "Build #{build.id} not found for locking"
56-
5754
existing = DropletModel.where(build_guid: build.guid).first
5855
if existing
5956
if build.cnb_lifecycle?
@@ -79,8 +76,6 @@ def find_or_create_buildpack_droplet(build)
7976
record_audit_event(droplet, build.package, user_audit_info_from_build(build))
8077
droplet
8178
end
82-
rescue Sequel::UniqueConstraintViolation
83-
DropletModel.where(build_guid: build.guid).first
8479
end
8580

8681
private

0 commit comments

Comments
 (0)