Fix Style/MapIntoArray rubocop errors

Author: moleske

app/presenters/v3/relationship_presenter.rb

@@ -16,13 +16,9 @@ def to_hash
         private
 
         def build_relations
-          data = []
-
-          @relationships.each do |relationship|
-            data << { name: relationship.name, guid: relationship.guid, link: "/v2/#{@relation_url}/#{relationship.guid}" }
+          @relationships.map do |relationship|
+            { name: relationship.name, guid: relationship.guid, link: "/v2/#{@relation_url}/#{relationship.guid}" }
           end
-
-          data
         end
       end
     end

app/presenters/v3/to_many_relationship_presenter.rb

@@ -25,13 +25,9 @@ def to_hash
         private
 
         def build_relations
-          data = []
-
-          @relationships.each do |relationship|
-            data << { guid: relationship.guid }
+          @relationships.map do |relationship|
+            { guid: relationship.guid }
           end
-
-          data
         end
 
         def build_links

docs/v3/helpers/docs_helpers.rb

@@ -13,14 +13,13 @@ def current_version
   def extract_table_of_contents(html)
     page = Nokogiri::HTML(html)
 
-    headings = []
-    page.css('h1,h2,h3').each do |heading|
-      headings.push({
-                      id: heading.attribute('id').to_s,
-                      text: heading.content,
-                      level: heading.name[1].to_i,
-                      children: []
-                    })
+    headings = page.css('h1,h2,h3').map do |heading|
+      {
+        id: heading.attribute('id').to_s,
+        text: heading.content,
+        level: heading.name[1].to_i,
+        children: []
+      }
     end
 
     [3, 2].each do |heading_level|

lib/cloud_controller/metrics/periodic_updater.rb

@@ -159,9 +159,8 @@ def update_webserver_stats
 
       local_stats = Puma.stats_hash
       worker_count = local_stats[:booted_workers]
-      worker_stats = []
-      local_stats[:worker_status].each do |worker_status|
-        worker_stats << {
+      worker_stats = local_stats[:worker_status].map do |worker_status|
+        {
           started_at: Time.parse(worker_status[:started_at]).utc.to_i,
           index: worker_status[:index],
           pid: worker_status[:pid],