rubocop formatting

Author: a18e

app/messages/manifest_routes_update_message.rb

@@ -18,10 +18,10 @@ def validate(record)
           return
         end
 
-        if contains_invalid_lb_algo?(record.routes)
-          record.errors.add(:routes, message: 'contains an invalid loadbalancing-algorithm option')
-          return
-        end
+        return unless contains_invalid_lb_algo?(record.routes)
+
+        record.errors.add(:routes, message: 'contains an invalid loadbalancing-algorithm option')
+        nil
       end
 
       def is_not_array?(routes)

app/messages/route_create_message.rb

@@ -91,7 +91,5 @@ def domain_guid
         HashUtils.dig(domain, :data, :guid)
       end
     end
-
-
   end
 end

app/messages/route_options_message.rb

@@ -2,7 +2,6 @@
 
 module VCAP::CloudController
   class RouteOptionsMessage < BaseMessage
-
     VALID_MANIFEST_ROUTE_OPTIONS = %i[loadbalancing-algorithm].freeze
     VALID_ROUTE_OPTIONS = %i[lb_algo].freeze
     VALID_LOADBALANCING_ALGORITHMS = %w[round-robin least-connections].freeze

app/messages/route_update_message.rb

@@ -16,6 +16,5 @@ def options_message
     validates_with OptionsValidator, if: options_requested?
 
     validates_with NoAdditionalKeysValidator
-
   end
 end

app/messages/validators.rb

@@ -242,7 +242,6 @@ def validate(record)
 
   class OptionsValidator < ActiveModel::Validator
     def validate(record)
-
       # Empty option hashes are allowed, so we skip further validation
       record.options.blank? && return
 

app/presenters/v3/route_presenter.rb

@@ -48,9 +48,7 @@ def to_hash
         },
         links: build_links
       }
-      unless route.options.nil?
-        hash.merge!(options: route.options)
-      end
+      hash.merge!(options: route.options) unless route.options.nil?
 
       @decorators.reduce(hash) { |memo, d| d.decorate(memo, [route]) }
     end

lib/cloud_controller/app_manifest/manifest_route.rb

@@ -6,7 +6,7 @@ class ManifestRoute
     SUPPORTED_TCP_SCHEMES = %w[tcp unspecified].freeze
     WILDCARD_HOST = '*'.freeze
 
-    def self.parse(route, options = nil)
+    def self.parse(route, options=nil)
       parsed_uri = Addressable::URI.heuristic_parse(route, scheme: 'unspecified')
 
       attrs = if parsed_uri.nil?

spec/request/space_manifests_spec.rb

@@ -749,11 +749,9 @@
 
             app1_model.reload
             expect(app1_model.routes.first.options).to eq({ 'lb_algo' => 'least-connections' })
-
           end
         end
       end
-
     end
 
     describe 'audit events' do

spec/unit/lib/cloud_controller/app_manifest/manifest_route_spec.rb

@@ -119,7 +119,7 @@ module VCAP::CloudController
 
         context 'when there is an invalid loadbalancing-algorithm' do
           let(:route) { 'http://example.com' }
-          let(:options) { { :'loadbalancing-algorithm' => 'invalid' } }
+          let(:options) { { 'loadbalancing-algorithm': 'invalid' } }
 
           it 'is invalid' do
             manifest_route = ManifestRoute.parse(route, options)

spec/unit/messages/manifest_routes_update_message_spec.rb

@@ -230,7 +230,7 @@ module VCAP::CloudController
           { 'routes' =>
               [
                 { 'route' => 'existing.example.com',
-                  'options' => {'invalid' => 'invalid'} }
+                  'options' => { 'invalid' => 'invalid' } }
               ] }
         end