App state is not updating in cf cli and appsman ui when the app is down

Fix Rubocop error

Author: nookala

lib/cloud_controller/diego/reporters/instances_stats_reporter.rb

@@ -49,12 +49,14 @@ def actual_lrp_info(process, stats=nil, quota_stats=nil, log_cache_errors=nil, i
 
         bbs_instances_client.lrp_instances(process).each do |actual_lrp|
           next unless actual_lrp.actual_lrp_key.index < process.instances
+
           # if an LRP already exists with the same index use the one with the latest since value
 
           if lrp_instances.include?(actual_lrp.actual_lrp_key.index)
-          
+
             existing_lrp = lrp_instances[actual_lrp.actual_lrp_key.index]
-            next if (actual_lrp.since < existing_lrp.since)
+            next if actual_lrp.since < existing_lrp.since
+
             lrp_instances.delete(actual_lrp.actual_lrp_key.index)
             result.delete(actual_lrp.actual_lrp_key.index)
             lrp_instances[actual_lrp.actual_lrp_key.index] = actual_lrp
@@ -66,7 +68,7 @@ def actual_lrp_info(process, stats=nil, quota_stats=nil, log_cache_errors=nil, i
           result[actual_lrp.actual_lrp_key.index] = info
           lrp_instances[actual_lrp.actual_lrp_key.index] = actual_lrp
         end
-  
+
         fill_unreported_instances_with_down_instances(result, process, flat: false)
 
         warnings = [log_cache_errors].compact

spec/unit/lib/cloud_controller/diego/reporters/instances_stats_reporter_spec.rb

@@ -159,7 +159,7 @@ def make_actual_lrp(instance_guid:, index:, state:, error:, since:)
           end
           let(:actual_lrp_2) do
             make_actual_lrp(
-              instance_guid: 'instance-a', index: 0, state: ::Diego::ActualLRPState::RUNNING, error: 'some-details', since: two_days_ago_since_epoch_ns-1000
+              instance_guid: 'instance-a', index: 0, state: ::Diego::ActualLRPState::RUNNING, error: 'some-details', since: two_days_ago_since_epoch_ns - 1000
             ).tap do |actual_lrp|
               actual_lrp.actual_lrp_net_info = lrp_1_net_info
             end
@@ -175,7 +175,7 @@ def make_actual_lrp(instance_guid:, index:, state:, error:, since:)
 
           let(:actual_lrp_4) do
             make_actual_lrp(
-              instance_guid: 'instance-b', index: 1, state: ::Diego::ActualLRPState::CLAIMED, error: 'some-details', since: two_days_ago_since_epoch_ns-1000
+              instance_guid: 'instance-b', index: 1, state: ::Diego::ActualLRPState::CLAIMED, error: 'some-details', since: two_days_ago_since_epoch_ns - 1000
             ).tap do |actual_lrp|
               actual_lrp.actual_lrp_net_info = lrp_1_net_info
             end
@@ -192,8 +192,6 @@ def make_actual_lrp(instance_guid:, index:, state:, error:, since:)
           end
         end
 
-
-
         context 'when a NoRunningInstances error is thrown for desired_lrp and it exists an actual_lrp' do
           let(:error) { CloudController::Errors::NoRunningInstances.new('No running instances ruh roh') }
           let(:expected_stopping_response) do