Remove db migration and config parameter

To ensure users cannot run create multiple service bindings during the
bosh deployment (when old and new code is running) we need to first
introduce the new validation logic so that we can safely remove the
unique constraints in the next capi release.

Author: johha

app/actions/service_credential_binding_app_create.rb

@@ -109,7 +109,12 @@ def event_repository
       end
 
       def max_bindings_per_app_service_instance
-        VCAP::CloudController::Config.config.get(:max_service_credential_bindings_per_app_service_instance)
+        1
+        # NOTE: This is hard-coded to 1 for now to preserve the old uniqueness behavior.
+        # TODO: Once the DB migration that drops the unique constraints for service bindings has been released,
+        #       this should be switched to read from config:
+        #       VCAP::CloudController::Config.config.get(:max_service_credential_bindings_per_app_service_instance)
+        # TODO: Also remove skips in related specs.
       end
 
       def app_is_required!

db/migrations/20250731071027_allow_multiple_service_bindings.rb

@@ -409,8 +409,6 @@ class ApiSchema < VCAP::Config
             optional(:query_raise_on_mismatch) => bool
           },
 
-          max_service_credential_bindings_per_app_service_instance: Integer,
-
           max_labels_per_resource: Integer,
           max_annotations_per_resource: Integer,
 

lib/cloud_controller/config_schemas/api_schema.rb

@@ -219,7 +219,6 @@ class WorkerSchema < VCAP::Config
           route_services_enabled: bool,
 
           max_manifest_service_binding_poll_duration_in_seconds: Integer,
-          max_service_credential_bindings_per_app_service_instance: Integer,
 
           max_labels_per_resource: Integer,
           max_annotations_per_resource: Integer,

lib/cloud_controller/config_schemas/worker_schema.rb

@@ -1276,8 +1276,6 @@ def check_filtered_bindings(*bindings)
 
         context 'when only one binding per app and service instance is allowed' do
           before do
-            TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1)
-
             it 'returns 422 when the binding already exists' do
               api_call.call admin_headers
               expect(last_response.status).to eq(201).or eq(202)

spec/migrations/20250731071027_allow_multiple_service_bindings_spec.rb

@@ -69,7 +69,8 @@ module V3
           context 'when a binding already exists' do
             let!(:binding) { ServiceBinding.make(service_instance:, app:) }
 
-            before { TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1) }
+            # TODO: Once the unique constraints to allow multiple bindings are removed, this needs to be set to 1
+            # before { TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1) }
 
             context 'when no last binding operation exists' do
               it 'raises an error' do
@@ -160,7 +161,8 @@ module V3
             end
             let(:service_instance2) { ManagedServiceInstance.make(**si_details) }
 
-            before { TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1) }
+            # TODO: Once the unique constraints to allow multiple bindings are removed, this needs to be set to 1
+            # before { TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1) }
 
             it 'raises an error when the binding name already exists' do
               # First request, should succeed
@@ -186,7 +188,8 @@ module V3
               )
             end
 
-            before { TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1) }
+            # TODO: Once the unique constraints to allow multiple bindings are removed, this needs to be set to 1
+            # before { TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1) }
 
             it 'raises an error when the app is already bound to the service instance' do
               # First request, should succeed
@@ -211,7 +214,8 @@ module V3
             let(:binding_1) { ServiceBinding.make(service_instance: service_instance, app: app, name: nil) }
 
             before do
-              TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1)
+              # TODO: Once the unique constraints to allow multiple bindings are removed, this needs to be set to 1
+              # TestConfig.override(max_service_credential_bindings_per_app_service_instance: 1)
               binding_1.save_with_attributes_and_new_operation({}, { type: 'create', state: 'succeeded' })
             end
 
@@ -230,10 +234,10 @@ module V3
           end
 
           context 'when multiple bindings are allowed' do
-            let!(:binding_1) { ServiceBinding.make(service_instance:, app:, name:) }
-            let!(:binding_2) { ServiceBinding.make(service_instance:, app:, name:) }
-
             before do
+              skip 'this test can be enabled when the service bindings unique constraints are removed and max_bindings_per_app_service_instance can be configured'
+              binding_1 = ServiceBinding.make(service_instance:, app:, name:)
+              binding_2 = ServiceBinding.make(service_instance:, app:, name:)
               binding_1.save_with_attributes_and_new_operation({}, { type: 'create', state: 'succeeded' })
               binding_2.save_with_attributes_and_new_operation({}, { type: 'create', state: 'succeeded' })
             end