Remove stringify conversion in deployment model

Author: Samze

app/models/runtime/deployment_model.rb

@@ -94,10 +94,10 @@ def before_update
     def before_create
       self.canary_current_step = 1 if strategy == DeploymentModel::CANARY_STRATEGY
 
-      unless canary_steps.nil?
-        # ensure that canary steps are in the correct format for serialization
-        self.canary_steps = canary_steps.map(&:stringify_keys)
-      end
+      # unless canary_steps.nil?
+      #   # ensure that canary steps are in the correct format for serialization
+      #   self.canary_steps = canary_steps.map(&:stringify_keys)
+      # end
       super
     end
 

db/migrations/20250130172009_add_canary_steps_to_deployments.rb

@@ -1,7 +1,6 @@
 Sequel.migration do
   up do
     alter_table(:deployments) do
-      # TODO: what size?
       add_column :canary_steps, String, size: 4096
       add_column :canary_current_step, :integer
     end

spec/unit/actions/deployment_create_spec.rb

@@ -610,6 +610,7 @@ module VCAP::CloudController
 
               it 'saves the canary steps' do
                 deployment = DeploymentCreate.create(app:, message:, user_audit_info:)
+                deployment.reload
                 expect(deployment.canary_steps).to eq([{ 'instance_weight' => 40 }, { 'instance_weight' => 80 }])
               end
             end
@@ -1151,7 +1152,7 @@ module VCAP::CloudController
                                             strategy: strategy,
                                             options: {
                                               max_in_flight: max_in_flight,
-                                              canary: { steps: [{ instance_weight: 66 }, { instance_weight: 99 }] }
+                                              canary: { steps: [{ instance_weight: 33 }, { instance_weight: 99 }] }
                                             }
                                           })
             end
@@ -1163,7 +1164,9 @@ module VCAP::CloudController
                 deployment = DeploymentCreate.create(app:, message:, user_audit_info:)
               end.to change(DeploymentModel, :count).by(1)
 
-              expect(deployment.canary_steps).to eq([{ 'instance_weight' => 66 }, { 'instance_weight' => 99 }])
+              deployment.reload
+
+              expect(deployment.canary_steps).to eq([{ 'instance_weight' => 33 }, { 'instance_weight' => 99 }])
             end
 
             it 'sets starting instances to max in flight' do
@@ -1180,7 +1183,7 @@ module VCAP::CloudController
                 DeploymentCreate.create(app:, message:, user_audit_info:)
 
                 deploying_web_process = app.reload.newest_web_process
-                expect(deploying_web_process.instances).to eq(2)
+                expect(deploying_web_process.instances).to eq(1)
               end
             end
           end