refac: ApiError is thrown in failed status

Author: serdarozerr

app/actions/v3/service_instance_create_managed.rb

@@ -73,7 +73,6 @@ def provision(instance, parameters: {}, accepts_incomplete: false)
         end
       rescue StandardError => e
         save_failed_state(instance, e)
-
         raise e
       end
 
@@ -100,7 +99,7 @@ def poll(instance)
           raise LastOperationFailedState.new(last_operation_result[:last_operation][:description])
         end
       rescue LastOperationFailedState => e
-        raise e
+        raise CloudController::Errors::ApiError.new_from_details('UnableToPerform', 'create managed', e.message)
       rescue StandardError => e
         save_failed_state(instance, e)
         raise e

spec/unit/actions/v3/service_instance_create_managed_spec.rb

@@ -681,8 +681,7 @@ module V3
           it 'raises and updates the last operation description' do
             expect do
               action.poll(service_instance)
-            end.to raise_error(VCAP::CloudController::V3::ServiceInstanceCreateManaged::LastOperationFailedState)
-
+            end.to raise_error(CloudController::Errors::ApiError)
             expect(ServiceInstance.first.last_operation.type).to eq('create')
             expect(ServiceInstance.first.last_operation.state).to eq('failed')
             expect(ServiceInstance.first.last_operation.broker_provided_operation).to eq(operation_id)