cleanup: remove unused enum

add constant for VALID_LOADBALANCING_ALGORITHMS

Author: a18e

app/messages/manifest_routes_update_message.rb

@@ -43,7 +43,7 @@ def contains_invalid_lb_algo?(routes)
         routes.any? do |r|
           next unless r[:options] && r[:options][:'loadbalancing-algorithm']
 
-          return true if r[:options][:'loadbalancing-algorithm'] && %w[round-robin least-connections].exclude?(r[:options][:'loadbalancing-algorithm'])
+          return true if r[:options][:'loadbalancing-algorithm'] && RouteOptionsMessage::VALID_LOADBALANCING_ALGORITHMS.exclude?(r[:options][:'loadbalancing-algorithm'])
         end
       end
     end

app/messages/route_options_message.rb

@@ -2,10 +2,13 @@
 
 module VCAP::CloudController
   class RouteOptionsMessage < BaseMessage
+
+    VALID_LOADBALANCING_ALGORITHMS = %w[round-robin least-connections].freeze
+
     register_allowed_keys %i[lb_algo]
     validates_with NoAdditionalKeysValidator
     validates :lb_algo,
-              inclusion: { in: %w[least-connections round-robin], message: "'%<value>s' is not a supported load-balancing algorithm" },
+              inclusion: { in: VALID_LOADBALANCING_ALGORITHMS, message: "'%<value>s' is not a supported load-balancing algorithm" },
               presence: true,
               allow_nil: true
   end

app/models/runtime/route.rb

@@ -6,11 +6,6 @@
 
 module VCAP::CloudController
 
-  class LBAlgorithmEnum
-    ROUND_ROBIN = 'round-robin'.freeze
-    LEAST_CONNECTION = 'least-connection'.freeze
-  end
-
   class Route < Sequel::Model
     class InvalidOrganizationRelation < CloudController::Errors::InvalidRelation; end