Can't push apps with app manifests if routes were shared

Rename method based on code review

Author: nookala

app/actions/manifest_route_update.rb

@@ -92,7 +92,7 @@ def find_or_create_valid_route(app, manifest_route, user_audit_info)
               domain: existing_domain,
               manifest_triggered: true
             )
-          elsif route.app_spaces_no_match?(app)
+          elsif !route.available_in_space?(app.space)
             raise InvalidRoute.new('Routes cannot be mapped to destinations in different spaces')
           elsif manifest_route[:options] && route[:options] != manifest_route[:options]
             # remove nil values from options

app/controllers/v3/routes_controller.rb

@@ -362,7 +362,7 @@ def validate_app_guids!(apps_hash, desired_app_guids)
   end
 
   def validate_app_spaces!(apps_hash, route)
-    return unless apps_hash.values.any? { |app| route.app_spaces_no_match?(app) }
+    return unless apps_hash.values.any? { |app| !route.available_in_space?(app.space) }
 
     unprocessable!("Routes destinations must be in either the route's space or the route's shared spaces")
   end

app/models/runtime/route.rb

@@ -194,8 +194,8 @@ def self.user_visibility_filter(user)
       }
     end
 
-    def app_spaces_no_match?(app)
-      app.space != space && shared_spaces.exclude?(app.space)
+    def available_in_space?(other_space)
+      other_space == space || shared_spaces.include?(other_space)
     end
 
     delegate :in_suspended_org?, to: :space

spec/unit/models/runtime/route_spec.rb

@@ -1578,13 +1578,13 @@ def assert_invalid_path(path)
         let!(:app) { AppModel.make }
         let!(:route) { Route.make(host: 'potato', domain: domain, path: '/some-path') }
 
-        it 'no space match and not shared and returns true' do
-          expect(route.app_spaces_no_match?(app)).to be(true)
+        it 'no space match and not shared and returns false' do
+          expect(route.available_in_space?(app.space)).to be(false)
         end
 
-        it 'match space and returns false' do
+        it 'match space and returns true' do
           route.space = app.space
-          expect(route.app_spaces_no_match?(app)).to be(false)
+          expect(route.available_in_space?(app.space)).to be(true)
         end
       end
 
@@ -1595,8 +1595,8 @@ def assert_invalid_path(path)
         let!(:route) { Route.make(host: 'potato', domain: domain, path: '/some-path') }
         let!(:shared_route) { route_share.create(route, [app.space], user_audit_info) }
 
-        it 'shared space match and returns false' do
-          expect(route.app_spaces_no_match?(app)).to be(false)
+        it 'shared space match and returns true' do
+          expect(route.available_in_space?(app.space)).to be(true)
         end
       end
     end