Add OpenTelemetry Tracing capabilities to Cloud Controller

In this change we implement Opentelemetry(OTel) tracing support for the ruby cloud_controller using the official(by OTel community) library opentelemetry-ruby.
It enables the cloud_controller itself to measure traces and spans and send them to a OpenTelemetryProtocol(OTLP) capable backend.

The recorded root span is stored in the with the service-name "cloud_controller_ng-api" or "cloud_controller_ng-worker".
A trace of an api call that starts a delayed_job will cause a link between this api call and the trace of the worker.
The worker inherits the sampling decision of the api call too, meaning a sampled api call will also lead to a sampled job run.
The service name can be used to find the trace in the attached backend. Job samples and Api samples will have a bidirectional link.

When disabled the code that load and initialise the framework as well as the middleware are not used to minimise impact on performance and bug surface.

Instrumentations:
The opentelemetry-ruby library offers a few out of the box instrumentations which extend key function calls in libraries automatically once loaded and measure span.
The used instrumentations and their respective roles include:
  - HttpClient: This instrumentation tracks outgoing HTTP requests executed with the httpclient gem.
  - HTTP: This instrumentations traces the HTTP client and server-side libraries.
  - Mysql2: This instrumentation detects queries, database calls, transactions, etc., made to MySQL using the Mysql2 gem.
  - Redis: This instrumentation traces all commands sent to Redis server using the redis-rb gem.
  - Rake: This instrumentation measures the execution time of your Rake tasks.
  - CCDelayedJob: This instrumentation traces the enqueue/job execute cycle within delayed jobs. This is a modified version of the DelayedJob instrumentation that propagates trace information so that bidirectional links can be set. It also records some cloud_controller specific job attributes when they are available.
  -  PG (Postgres): Postgres instrumentation captures SQL queries executed on a Postgres database.
The instrumentations automatically set spans into traces and spans, which are set manually in the code(OpenTelemetryMiddleware) to track specific activities. Manual spans include:
  - middleware-pre-app: This span measures the middleware before the application runs.
  - application: This span measures the application runtime(without middleware).

  Configuration
  To properly configure this functionality following properties will be
  introduced:
  - [otel][tracing][enabled]: Set this to true or false. If it's false, all functionality regarding OpenTelemetry Tracing is disabled.
  - [otel][tracing][api_url]: Set the URL for the API.
  - [otel][tracing][api_token]: Set the token for the API
  - [otel][tracing][redact][db_statemets]: Set this to true or false. If false the full sql statement will be provided as attribute in the spans of the mysql or pg instrumentation. If set to true, it will log the statements but will redact the query parameters as well as insert/update values by question marks.
  - [otel][tracing][sampling_ratio]: Set a float between 0.0 (=0%) and 1.0 (=100%) to define the probability with that traces are sampled.
  - [otel][tracing][propagation][accept_sampling_instruction] Set this to true or false. If true, the header passing the sampling value to the cloud_controller will be honoured and make the cloud_controller to also trace. If set to false the tracing information is parsed but it does not influence the sampling decision based on above sampling_ratio.
  - [otel][tracing][propagation][extractors]: Here you can set the list of propagators to be extracted. Extractors read the HTTP headers provided and deserialize the contained tracing information.
  - [otel][tracing][propagation][injectors]: Here you can set the list of propagators to be injected. Injectors serialize the tracing information into HTTP headers for propagation.

Propagation
Propagation refers to the process of moving tracing data using HTTP headers across service boundaries that can be linked together into a single trace.
Propagators accepted are:
  - tracecontext(https://www.w3.org/TR/trace-context/)
  - baggage(https://www.w3.org/TR/baggage/)
  - b3(https://github.com/openzipkin/b3-propagation)
  - b3multi(https://github.com/openzipkin/b3-propagation)
  - jaeger(https://www.jaegertracing.io/docs/1.56/client-libraries/#propagation-format)
  - xray(https://docs.aws.amazon.com/xray/latest/devguide/aws-xray.html#xray-concepts-tracingheader)
  - none

Propagators can be differentiated into extractors and injectors. Extractors are responsible for extracting trace context from incoming requests(incoming api calls), while injectors are responsible for injecting trace context into outgoing requests(e.g. to UAA or service brokers).
If more than one injector is configured in the HTTP Request, than the last propagator that can successfully process the supplied headers defines the inherited trace context, in case multiple conflicting trace headers are recieved.
If more than on extractor is configured, the CC will propagate the information in all configured formats.
The propagators tracecontext and jaeger also support baggage. With baggage key-value pairs can be added to the headers. If more than one propagation, which supports baggage, is present, the first baggage key-value pairs are being used.
The propagation functionality hereby replaces the zipkin middleware wich was removed, since it implemented the propagation(only, without the cloud_controller adding trace data) for the B3Multi Header exclusively.
The current implementation with OTel can be configured to offer the exact same functionality/behaviour.

Co-Authored-By: FlorianBraun <[email protected]>

Author: MarcWoern

Gemfile

@@ -68,6 +68,19 @@ gem 'fog-openstack'
 gem 'cf-uaa-lib', '~> 4.0.4'
 gem 'vcap-concurrency', git: 'https://github.com/cloudfoundry/vcap-concurrency.git', ref: '2a5b0179'
 
+gem 'opentelemetry-exporter-otlp', '~> 0.26.1'
+gem 'opentelemetry-instrumentation-delayed_job', '~> 0.22.1'
+gem 'opentelemetry-instrumentation-http_client', '~> 0.22.3'
+gem 'opentelemetry-instrumentation-mysql2', '~> 0.27.0'
+gem 'opentelemetry-instrumentation-net_http', '~> 0.22.4'
+gem 'opentelemetry-instrumentation-pg', '~> 0.27.1'
+gem 'opentelemetry-instrumentation-rake', '~> 0.2.1'
+gem 'opentelemetry-instrumentation-redis', '~> 0.25.3'
+gem 'opentelemetry-propagator-b3'
+gem 'opentelemetry-propagator-jaeger', '~> 0.21.0'
+gem 'opentelemetry-propagator-xray', '~> 0.22.1'
+gem 'opentelemetry-sdk', '~> 1.3'
+
 group :db do
   gem 'mysql2', '~> 0.5.6'
   gem 'pg'
@@ -84,6 +97,7 @@ group :test do
   gem 'rack-test'
   gem 'rspec', '~> 3.13.0'
   gem 'rspec_api_documentation', '>= 6.1.0'
+  gem 'rspec-benchmark', '~> 0.6.0'
   gem 'rspec-collection_matchers'
   gem 'rspec-instafail'
   gem 'rspec-its'

Gemfile.lock

@@ -110,6 +110,9 @@ GEM
     base64 (0.2.0)
     beefcake (1.0.0)
     benchmark (0.3.0)
+    benchmark-malloc (0.2.0)
+    benchmark-perf (0.6.0)
+    benchmark-trend (0.4.0)
     bigdecimal (3.1.7)
     bit-struct (0.17)
     builder (3.2.4)
@@ -351,6 +354,66 @@ GEM
     oj (3.16.3)
       bigdecimal (>= 3.0)
     openssl (3.2.0)
+    opentelemetry-api (1.2.5)
+    opentelemetry-common (0.20.1)
+      opentelemetry-api (~> 1.0)
+    opentelemetry-exporter-otlp (0.26.3)
+      google-protobuf (~> 3.14)
+      googleapis-common-protos-types (~> 1.3)
+      opentelemetry-api (~> 1.1)
+      opentelemetry-common (~> 0.20)
+      opentelemetry-sdk (~> 1.2)
+      opentelemetry-semantic_conventions
+    opentelemetry-helpers-mysql (0.1.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.20)
+    opentelemetry-helpers-sql-obfuscation (0.1.0)
+      opentelemetry-common (~> 0.20)
+    opentelemetry-instrumentation-base (0.22.3)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-registry (~> 0.1)
+    opentelemetry-instrumentation-delayed_job (0.22.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.22.1)
+    opentelemetry-instrumentation-http_client (0.22.3)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.20.0)
+      opentelemetry-instrumentation-base (~> 0.22.1)
+    opentelemetry-instrumentation-mysql2 (0.27.0)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-helpers-mysql
+      opentelemetry-helpers-sql-obfuscation
+      opentelemetry-instrumentation-base (~> 0.22.1)
+    opentelemetry-instrumentation-net_http (0.22.4)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.20.0)
+      opentelemetry-instrumentation-base (~> 0.22.1)
+    opentelemetry-instrumentation-pg (0.27.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-helpers-sql-obfuscation
+      opentelemetry-instrumentation-base (~> 0.22.1)
+    opentelemetry-instrumentation-rake (0.2.1)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-instrumentation-base (~> 0.22.1)
+    opentelemetry-instrumentation-redis (0.25.3)
+      opentelemetry-api (~> 1.0)
+      opentelemetry-common (~> 0.20.0)
+      opentelemetry-instrumentation-base (~> 0.22.1)
+    opentelemetry-propagator-b3 (0.21.0)
+      opentelemetry-api (~> 1.1)
+    opentelemetry-propagator-jaeger (0.21.1)
+      opentelemetry-api (~> 1.1)
+    opentelemetry-propagator-xray (0.22.1)
+      opentelemetry-api (~> 1.0)
+    opentelemetry-registry (0.3.0)
+      opentelemetry-api (~> 1.1)
+    opentelemetry-sdk (1.4.0)
+      opentelemetry-api (~> 1.1)
+      opentelemetry-common (~> 0.20)
+      opentelemetry-registry (~> 0.2)
+      opentelemetry-semantic_conventions
+    opentelemetry-semantic_conventions (1.10.0)
+      opentelemetry-api (~> 1.0)
     os (1.1.4)
     palm_civet (1.1.0)
     parallel (1.24.0)
@@ -435,6 +498,11 @@ GEM
       rspec-core (~> 3.13.0)
       rspec-expectations (~> 3.13.0)
       rspec-mocks (~> 3.13.0)
+    rspec-benchmark (0.6.0)
+      benchmark-malloc (~> 0.2)
+      benchmark-perf (~> 0.6)
+      benchmark-trend (~> 0.4)
+      rspec (>= 3.0)
     rspec-collection_matchers (1.2.1)
       rspec-expectations (>= 2.99.0.beta1)
     rspec-core (3.13.0)
@@ -635,6 +703,18 @@ DEPENDENCIES
   nokogiri (>= 1.10.5)
   oj
   openssl (>= 3.2)
+  opentelemetry-exporter-otlp (~> 0.26.1)
+  opentelemetry-instrumentation-delayed_job (~> 0.22.1)
+  opentelemetry-instrumentation-http_client (~> 0.22.3)
+  opentelemetry-instrumentation-mysql2 (~> 0.27.0)
+  opentelemetry-instrumentation-net_http (~> 0.22.4)
+  opentelemetry-instrumentation-pg (~> 0.27.1)
+  opentelemetry-instrumentation-rake (~> 0.2.1)
+  opentelemetry-instrumentation-redis (~> 0.25.3)
+  opentelemetry-propagator-b3
+  opentelemetry-propagator-jaeger (~> 0.21.0)
+  opentelemetry-propagator-xray (~> 0.22.1)
+  opentelemetry-sdk (~> 1.3)
   palm_civet
   parallel_tests
   pg
@@ -650,6 +730,7 @@ DEPENDENCIES
   rfc822
   roodi
   rspec (~> 3.13.0)
+  rspec-benchmark (~> 0.6.0)
   rspec-collection_matchers
   rspec-instafail
   rspec-its

app/jobs/cc_job.rb

@@ -1,6 +1,8 @@
 module VCAP::CloudController
   module Jobs
     class CCJob
+      attr_accessor :otel_tracing_carrier
+
       def reschedule_at(time, attempts)
         time + (attempts**4) + 5
       end

app/jobs/enqueuer.rb

@@ -5,6 +5,7 @@
 require 'jobs/logging_context_job'
 require 'jobs/timeout_job'
 require 'securerandom'
+require 'opentelemetry/sdk'
 
 module VCAP::CloudController
   module Jobs
@@ -26,8 +27,12 @@ def enqueue_pollable(existing_guid: nil)
 
         wrapped_job = yield wrapped_job if block_given?
 
-        delayed_job = enqueue_job(wrapped_job)
-        PollableJobModel.find_by_delayed_job(delayed_job)
+        tracer = OpenTelemetry.tracer_provider.tracer(self.class.name, '1.0.0')
+        job_handler = wrapped_job.handler.class.name.respond_to?(:split) ? wrapped_job.handler.class.name.split('::').last : wrapped_job.handler.class.name
+        tracer.in_span("enqueue-job: #{job_handler}", kind: :producer) do
+          delayed_job = enqueue_job(wrapped_job)
+          PollableJobModel.find_by_delayed_job(delayed_job)
+        end
       end
 
       def run_inline
@@ -42,7 +47,10 @@ def enqueue_job(job)
         @opts['guid'] = SecureRandom.uuid
         request_id = ::VCAP::Request.current_id
         timeout_job = TimeoutJob.new(job, job_timeout)
-        logging_context_job = LoggingContextJob.new(timeout_job, request_id)
+        logging_context_job = LoggingContextJob.new(
+          timeout_job,
+          request_id
+        )
         @opts[:priority] = job_priority unless @opts[:priority] || job_priority.nil?
         Delayed::Job.enqueue(logging_context_job, @opts)
       end

app/jobs/logging_context_job.rb

@@ -1,5 +1,6 @@
 require 'jobs/wrapping_job'
 require 'presenters/error_presenter'
+require 'opentelemetry/sdk'
 
 module VCAP::CloudController
   module Jobs

app/jobs/wrapping_job.rb

@@ -1,9 +1,11 @@
 require 'jobs/cc_job'
+require 'opentelemetry-sdk'
 
 module VCAP::CloudController
   module Jobs
     class WrappingJob < VCAP::CloudController::Jobs::CCJob
       attr_reader :handler
+      attr_accessor :otel_api_trace_carrier, :otel_job_trace_carrier
 
       def initialize(handler)
         @handler = handler

config/cloud_controller.yml

@@ -401,3 +401,16 @@ custom_metric_tag_prefix_list: ["metric.tag.cloudfoundry.org"]
 
 max_manifest_service_binding_poll_duration_in_seconds: 60
 update_metric_tags_on_rename: true
+
+otel:
+  tracing:
+    enabled: false
+    api_url: ''
+    api_token: ''
+    sampling_ratio: 1.0
+    redact:
+      db_statements: true
+    propagation:
+      accept_sampling_instruction: true
+      extractors: ['tracecontext', 'xray', 'jaeger', 'baggage', 'b3', 'b3multi']
+      injectors: ['tracecontext', 'xray', 'jaeger', 'baggage', 'b3', 'b3multi']

config/initializers/cloudfront_signer.rb

@@ -1,7 +1,7 @@
 require 'cloudfront-signer'
 
 module CCInitializers
-  def self.cloudfront_signer(cc_config)
+  def self.cloudfront_signer(cc_config, _)
     return if cc_config[:droplets].blank?
 
     cdn_config = cc_config[:droplets][:cdn]

config/initializers/delayed_job.rb

@@ -1,5 +1,5 @@
 module CCInitializers
-  def self.delayed_job(_)
+  def self.delayed_job(_, _)
     ::Delayed::Worker.backend = :sequel
   end
 end

config/initializers/honeycomb.rb

@@ -1,7 +1,7 @@
 require 'honeycomb-beeline'
 
 module CCInitializers
-  def self.honeycomb(cc_config)
+  def self.honeycomb(cc_config, _)
     return unless cc_config[:honeycomb]
 
     Honeycomb.configure do |hc|