Adjust unittest

Author: WeiQuan0605

lib/logcache/client.rb

@@ -47,11 +47,11 @@ def container_metrics(source_guid:, start_time:, end_time:, envelope_limit: DEFA
     def with_request_error_handling(_source_guid)
       tries ||= 3
       start_time = Time.now
-      yield
 
       # convert to milliseconds to get more precise information
       time_taken = (Time.now - start_time) * 1000
       logger.info("Response time: #{time_taken.round(2)} ms")
+      yield
     rescue StandardError => e
       raise CloudController::Errors::ApiError.new_from_details('ServiceUnavailable', 'Connection to Log Cache timed out') if e.is_a?(GRPC::DeadlineExceeded)
 

spec/logcache/client_spec.rb

@@ -36,7 +36,7 @@ module Logcache
             with(client_ca, client_key, client_cert).
             and_return(credentials)
           expect(Logcache::V1::Egress::Stub).to receive(:new).
-            with("#{host}:#{port}", credentials, channel_args: channel_arg_hash, timeout: 250).
+            with("#{host}:#{port}", credentials, channel_args: channel_arg_hash, timeout: 10).
             and_return(logcache_service)
           allow(Logcache::V1::ReadRequest).to receive(:new).and_return(logcache_request)
         end
@@ -68,7 +68,7 @@ module Logcache
             with(client_ca, client_key, client_cert).
             and_return(credentials)
           expect(Logcache::V1::Egress::Stub).to receive(:new).
-            with("#{host}:#{port}", credentials, channel_args: channel_arg_hash, timeout: 250).
+            with("#{host}:#{port}", credentials, channel_args: channel_arg_hash, timeout: 10).
             and_return(logcache_service)
           allow(client).to receive(:sleep)
           allow(Logcache::V1::ReadRequest).to receive(:new).and_return(logcache_request)
@@ -99,7 +99,7 @@ module Logcache
             with(client_ca, client_key, client_cert).
             and_return(credentials)
           expect(Logcache::V1::Egress::Stub).to receive(:new).
-            with("#{host}:#{port}", credentials, channel_args: channel_arg_hash, timeout: 250).
+            with("#{host}:#{port}", credentials, channel_args: channel_arg_hash, timeout: 10).
             and_return(logcache_service)
           allow(client).to receive(:sleep)
           allow(Logcache::V1::ReadRequest).to receive(:new).and_return(logcache_request)
@@ -130,7 +130,7 @@ module Logcache
             with(client_ca, client_key, client_cert).
             and_return(credentials)
           expect(Logcache::V1::Egress::Stub).to receive(:new).
-            with("#{host}:#{port}", credentials, channel_args: channel_arg_hash, timeout: 250).
+            with("#{host}:#{port}", credentials, channel_args: channel_arg_hash, timeout: 10).
             and_return(logcache_service)
           allow(client).to receive(:sleep)
           allow(Logcache::V1::ReadRequest).to receive(:new).and_return(logcache_request)
@@ -164,7 +164,7 @@ module Logcache
         before do
           expect(GRPC::Core::ChannelCredentials).not_to receive(:new)
           expect(Logcache::V1::Egress::Stub).to receive(:new).
-            with("#{host}:#{port}", :this_channel_is_insecure, timeout: 250).
+            with("#{host}:#{port}", :this_channel_is_insecure, timeout: 10).
             and_return(logcache_service)
           allow(Logcache::V1::ReadRequest).to receive(:new).and_return(logcache_request)
         end