WIP: Add options case for route_update_spec

Author: hoffmaen

spec/unit/actions/route_update_spec.rb

@@ -16,6 +16,9 @@ module VCAP::CloudController
         beet: 'formanova'
       }
     end
+    let(:old_options) do
+      '{"lb_algo": "round-robin"}'
+    end
     let(:new_labels) do
       {
         cuisine: 'thai',
@@ -33,6 +36,9 @@ module VCAP::CloudController
         metadata: {
           labels: new_labels,
           annotations: new_annotations
+        },
+        options: {
+          lb_algo: 'round-robin'
         }
       }
     end
@@ -41,7 +47,96 @@ module VCAP::CloudController
     let(:route) { Route.make }
 
     subject { RouteUpdate.new }
-    describe '#update' do
+    describe '#update metadata' do
+      context 'when the route has no existing metadata' do
+        context 'when no metadata is specified' do
+          let(:body) do
+            {}
+          end
+
+          it 'adds no metadata' do
+            expect(message).to be_valid
+            subject.update(route:, message:)
+            route.reload
+            expect(route.labels.size).to eq(0)
+            expect(route.annotations.size).to eq(0)
+          end
+        end
+
+        context 'when metadata is specified' do
+          it 'updates the route metadata' do
+            expect(message).to be_valid
+            subject.update(route:, message:)
+
+            route.reload
+            expect(route).to have_labels(
+              { prefix: 'doordash.com', key_name: 'potato', value: 'mashed' },
+              { prefix: nil, key_name: 'fruit', value: 'strawberries' },
+              { prefix: nil, key_name: 'cuisine', value: 'thai' }
+            )
+            expect(route).to have_annotations(
+              { key_name: 'potato', value: 'idaho' }
+            )
+          end
+        end
+      end
+
+      context 'when the route has existing metadata' do
+        before do
+          VCAP::CloudController::LabelsUpdate.update(route, old_labels, VCAP::CloudController::RouteLabelModel)
+          VCAP::CloudController::AnnotationsUpdate.update(route, old_annotations, VCAP::CloudController::RouteAnnotationModel)
+        end
+
+        context 'when no metadata is specified' do
+          let(:body) do
+            {}
+          end
+
+          it 'adds no metadata' do
+            expect(message).to be_valid
+            subject.update(route:, message:)
+            route.reload
+            expect(route).to have_labels(
+              { prefix: nil, key_name: 'fruit', value: 'peach' },
+              { prefix: nil, key_name: 'clothing', value: 'blouse' }
+            )
+            expect(route).to have_annotations(
+              { key_name: 'potato', value: 'celandine' },
+              { key_name: 'beet', value: 'formanova' }
+            )
+          end
+        end
+
+        context 'when metadata is specified' do
+          let(:body) do
+            {
+              metadata: {
+                labels: new_labels.merge(fruit: nil, newstuff: 'here'),
+                annotations: new_annotations.merge(beet: nil, asparagus: 'crunchy')
+              }
+            }
+          end
+
+          it 'updates some, deletes nils, leaves unspecified fields alone' do
+            expect(message).to be_valid
+            subject.update(route:, message:)
+            route.reload
+
+            expect(route).to have_labels(
+              { prefix: 'doordash.com', key_name: 'potato', value: 'mashed' },
+              { prefix: nil, key_name: 'clothing', value: 'blouse' },
+              { prefix: nil, key_name: 'newstuff', value: 'here' },
+              { prefix: nil, key_name: 'cuisine', value: 'thai' }
+            )
+            expect(route).to have_annotations(
+              { key_name: 'potato', value: 'idaho' },
+              { key_name: 'asparagus', value: 'crunchy' }
+            )
+          end
+        end
+      end
+    end
+    describe '#update options' do
       context 'when the route has no existing metadata' do
         context 'when no metadata is specified' do
           let(:body) do
@@ -71,6 +166,7 @@ module VCAP::CloudController
             expect(route).to have_annotations(
               { key_name: 'potato', value: 'idaho' }
             )
+            expect(route[:options]).to eq('{"lb_algo":"round-robin"}')
           end
         end
       end
@@ -79,6 +175,7 @@ module VCAP::CloudController
         before do
           VCAP::CloudController::LabelsUpdate.update(route, old_labels, VCAP::CloudController::RouteLabelModel)
           VCAP::CloudController::AnnotationsUpdate.update(route, old_annotations, VCAP::CloudController::RouteAnnotationModel)
+          route[:options] = '{"lb_algo": "round-robin"}'
         end
 
         context 'when no metadata is specified' do
@@ -98,6 +195,7 @@ module VCAP::CloudController
               { key_name: 'potato', value: 'celandine' },
               { key_name: 'beet', value: 'formanova' }
             )
+            expect(route.options).to include({ 'lb_algo' => 'round-robin' })
           end
         end
 
@@ -130,5 +228,6 @@ module VCAP::CloudController
         end
       end
     end
+
   end
 end