Initial attempt at upgrading to Ruby 3.4

Author: sethboyles

.ruby-version

@@ -1 +1 @@
-3.3.5
+3.4.2

Gemfile

@@ -19,6 +19,7 @@ gem 'loggregator_emitter', '~> 5.0'
 gem 'membrane', '~> 1.0'
 gem 'mime-types', '~> 3.6'
 gem 'multipart-parser'
+gem 'mutex_m'
 gem 'netaddr', '>= 2.0.4'
 gem 'net-ssh'
 gem 'newrelic_rpm'
@@ -39,10 +40,10 @@ gem 'sinatra-contrib'
 gem 'sshkey'
 gem 'statsd-ruby', '~> 1.5.0'
 gem 'steno'
+gem 'syslog'
 gem 'talentbox-delayed_job_sequel', '~> 4.3.0'
 gem 'thin'
 gem 'vmstat', '~> 2.3'
-
 # Rails Components
 gem 'actionpack', '~> 7.2.2'
 gem 'actionview', '~> 7.2.1'

Gemfile.lock

@@ -554,6 +554,7 @@ GEM
       fluent-logger
       yajl-ruby (~> 1.0)
     stringio (3.1.2)
+    syslog (0.1.1)
     talentbox-delayed_job_sequel (4.3.0)
       delayed_job (~> 4.1.0)
       sequel (>= 3.38, < 6.0)
@@ -631,6 +632,7 @@ DEPENDENCIES
   mime-types (~> 3.6)
   mock_redis
   multipart-parser
+  mutex_m
   mysql2 (~> 0.5.6)
   net-ssh
   netaddr (>= 2.0.4)
@@ -676,6 +678,7 @@ DEPENDENCIES
   sshkey
   statsd-ruby (~> 1.5.0)
   steno
+  syslog
   talentbox-delayed_job_sequel (~> 4.3.0)
   thin
   timecop

db/migrations/20220601183937_create_asg_lastest_updates.rb

@@ -1,7 +1,7 @@
 Sequel.migration do
   change do
     create_table :asg_timestamps do
-      primary_key name: :id
+      primary_key '{:name=>:id}'
       Timestamp :last_update
     end
   end

db/migrations/20221003231438_correct_asg_latest_update_id_column_name.rb

@@ -1,7 +1,7 @@
 Sequel.migration do
   change do
     alter_table :asg_timestamps do
-      rename_column :'{:name=>:id}', :id
+      rename_column '{:name=>:id}', :id
     end
   end
 end

spec/request/admin_actions_spec.rb

@@ -14,6 +14,7 @@
       h = Hash.new(
         { code: 403 }.freeze
       )
+
       h['admin'] = {
         code: 202
       }

spec/request/app_features_spec.rb

@@ -60,6 +60,7 @@
 
       let(:expected_codes_and_responses) do
         h = Hash.new({ code: 404 }.freeze)
+
         %w[admin admin_read_only global_auditor space_developer space_manager space_auditor org_manager
            space_supporter].each do |r|
           h[r] = { code: 200, response_object: features_response_object }
@@ -78,6 +79,7 @@
   describe 'GET /v3/apps/:guid/features/:name' do
     let(:expected_codes_and_responses) do
       h = Hash.new({ code: 404 }.freeze)
+
       %w[admin admin_read_only global_auditor space_developer space_manager space_auditor org_manager
          space_supporter].each do |r|
         h[r] = { code: 200, response_object: feature_response_object }
@@ -161,8 +163,9 @@
 
       let(:expected_codes_and_responses) do
         h = Hash.new({ code: 403, errors: CF_NOT_AUTHORIZED }.freeze)
+
         %w[no_role org_auditor org_billing_manager].each { |r| h[r] = { code: 404 } }
-        %w[admin space_developer].each { |r| h[r] = { code: 200, response_object: feature_response_object } }
+        %w[admin space_devµeloper].each { |r| h[r] = { code: 200, response_object: feature_response_object } }
         h
       end
 

spec/request/stacks_spec.rb

@@ -56,7 +56,11 @@
         end
 
         let(:expected_codes_and_responses) do
+<<<<<<< HEAD
           Hash.new({ code: 200, response_objects: stacks_response_objects }.freeze)
+=======
+          Hash.new({ code: 200, response_objects: stacks_response_objects })
+>>>>>>> f9c219ec5 (Initial attempt at upgrading to Ruby 3.4)
         end
         let!(:stack1) { VCAP::CloudController::Stack.make }
         let!(:stack2) { VCAP::CloudController::Stack.make(name: default_stack_name) }
@@ -335,7 +339,11 @@
       }
     end
     let(:expected_codes_and_responses) do
+<<<<<<< HEAD
       Hash.new({ code: 200, response_object: stacks_response_object }.freeze)
+=======
+      Hash.new({ code: 200, response_object: stacks_response_object })
+>>>>>>> f9c219ec5 (Initial attempt at upgrading to Ruby 3.4)
     end
 
     it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS
@@ -548,7 +556,11 @@
       let(:api_call) { ->(user_headers) { get "/v3/stacks/#{stack.guid}/apps", nil, user_headers } }
 
       let(:expected_codes_and_responses) do
+<<<<<<< HEAD
         h = Hash.new({ code: 200, response_guids: [app_model1.guid, app_model2.guid] }.freeze)
+=======
+        h = Hash.new({ code: 200, response_guids: [app_model1.guid, app_model2.guid] })
+>>>>>>> f9c219ec5 (Initial attempt at upgrading to Ruby 3.4)
 
         h['org_auditor'] = {
           code: 200,