Skip to content

Commit f8e1b69

Browse files
build(deps): bump actionview, activemodel, actionpack and railties (#4141)
* build(deps): bump actionview, activemodel, actionpack and railties Bumps [actionview](https://github.com/rails/rails), [activemodel](https://github.com/rails/rails), [actionpack](https://github.com/rails/rails) and [railties](https://github.com/rails/rails). These dependencies needed to be updated together. Updates `actionview` from 7.2.2.1 to 8.0.1 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.0.1/actionview/CHANGELOG.md) - [Commits](rails/rails@v7.2.2.1...v8.0.1) Updates `activemodel` from 7.2.2.1 to 8.0.1 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.0.1/activemodel/CHANGELOG.md) - [Commits](rails/rails@v7.2.2.1...v8.0.1) Updates `actionpack` from 7.2.2.1 to 8.0.1 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.0.1/actionpack/CHANGELOG.md) - [Commits](rails/rails@v7.2.2.1...v8.0.1) Updates `railties` from 7.2.2.1 to 8.0.1 - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v8.0.1/railties/CHANGELOG.md) - [Commits](rails/rails@v7.2.2.1...v8.0.1) --- updated-dependencies: - dependency-name: actionview dependency-type: direct:production update-type: version-update:semver-major - dependency-name: activemodel dependency-type: direct:production update-type: version-update:semver-major - dependency-name: actionpack dependency-type: direct:production update-type: version-update:semver-major - dependency-name: railties dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * Update uri from 0.12.3 to 0.13.1 The activesupport gem needs uri >= 0.13.1, but Ruby 3.2 includes uri 0.12.3. As switching to the latest uri version (1.0.2) causes several test failures, we stick to the minimal required version 0.13.1. In Ruby 3.3 uri 0.13.1 will be included, but Ruby 3.4 will update to >1, so additional work needs to be done for this Ruby update. * Update delayed_job version check The latest delayed_job version (4.1.13) does not contain any code changes, but only metadata changes to support Rails 8. * Remove compatibility patch for Rails upgrade * Opt-in to new 'to_time' behavior (i.e. preserve receiver timezone) --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Philipp Thun <[email protected]>
1 parent 17e9190 commit f8e1b69

File tree

6 files changed

+32
-151
lines changed

6 files changed

+32
-151
lines changed

Gemfile

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -41,13 +41,14 @@ gem 'statsd-ruby', '~> 1.5.0'
4141
gem 'steno'
4242
gem 'talentbox-delayed_job_sequel', '~> 4.3.0'
4343
gem 'thin'
44+
gem 'uri', '~> 0.13'
4445
gem 'vmstat', '~> 2.3'
4546

4647
# Rails Components
47-
gem 'actionpack', '~> 7.2.2'
48-
gem 'actionview', '~> 7.2.1'
49-
gem 'activemodel', '~> 7.2.2'
50-
gem 'railties', '~> 7.2.1'
48+
gem 'actionpack', '~> 8.0.1'
49+
gem 'actionview', '~> 8.0.1'
50+
gem 'activemodel', '~> 8.0.1'
51+
gem 'railties', '~> 8.0.1'
5152

5253
gem 'azure-storage-blob', git: 'https://github.com/sethboyles/azure-storage-ruby.git', branch: 'x-ms-blob-content-type-fix-1.1'
5354

Gemfile.lock

Lines changed: 22 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -42,26 +42,25 @@ GIT
4242
GEM
4343
remote: https://rubygems.org/
4444
specs:
45-
actionpack (7.2.2.1)
46-
actionview (= 7.2.2.1)
47-
activesupport (= 7.2.2.1)
45+
actionpack (8.0.1)
46+
actionview (= 8.0.1)
47+
activesupport (= 8.0.1)
4848
nokogiri (>= 1.8.5)
49-
racc
50-
rack (>= 2.2.4, < 3.2)
49+
rack (>= 2.2.4)
5150
rack-session (>= 1.0.1)
5251
rack-test (>= 0.6.3)
5352
rails-dom-testing (~> 2.2)
5453
rails-html-sanitizer (~> 1.6)
5554
useragent (~> 0.16)
56-
actionview (7.2.2.1)
57-
activesupport (= 7.2.2.1)
55+
actionview (8.0.1)
56+
activesupport (= 8.0.1)
5857
builder (~> 3.1)
5958
erubi (~> 1.11)
6059
rails-dom-testing (~> 2.2)
6160
rails-html-sanitizer (~> 1.6)
62-
activemodel (7.2.2.1)
63-
activesupport (= 7.2.2.1)
64-
activesupport (7.2.2.1)
61+
activemodel (8.0.1)
62+
activesupport (= 8.0.1)
63+
activesupport (8.0.1)
6564
base64
6665
benchmark (>= 0.3)
6766
bigdecimal
@@ -73,6 +72,7 @@ GEM
7372
minitest (>= 5.1)
7473
securerandom (>= 0.3)
7574
tzinfo (~> 2.0, >= 2.0.5)
75+
uri (>= 0.13.1)
7676
addressable (2.8.7)
7777
public_suffix (>= 2.0.2, < 7.0)
7878
aliyun-sdk (0.8.0)
@@ -135,8 +135,8 @@ GEM
135135
irb (~> 1.10)
136136
reline (>= 0.3.8)
137137
declarative (0.0.20)
138-
delayed_job (4.1.12)
139-
activesupport (>= 3.0, < 8.0)
138+
delayed_job (4.1.13)
139+
activesupport (>= 3.0, < 9.0)
140140
diff-lcs (1.6.1)
141141
digest-xxhash (0.2.9)
142142
docile (1.1.5)
@@ -396,9 +396,9 @@ GEM
396396
rails-html-sanitizer (1.6.2)
397397
loofah (~> 2.21)
398398
nokogiri (>= 1.15.7, != 1.16.7, != 1.16.6, != 1.16.5, != 1.16.4, != 1.16.3, != 1.16.2, != 1.16.1, != 1.16.0.rc1, != 1.16.0)
399-
railties (7.2.2.1)
400-
actionpack (= 7.2.2.1)
401-
activesupport (= 7.2.2.1)
399+
railties (8.0.1)
400+
actionpack (= 8.0.1)
401+
activesupport (= 8.0.1)
402402
irb (~> 1.13)
403403
rackup (>= 1.0.0)
404404
rake (>= 12.2)
@@ -411,7 +411,7 @@ GEM
411411
ffi (~> 1.0)
412412
rbs (3.9.2)
413413
logger
414-
rdoc (6.13.1)
414+
rdoc (6.11.0)
415415
psych (>= 4.0.0)
416416
redis (5.4.0)
417417
redis-client (>= 0.22.0)
@@ -585,6 +585,7 @@ GEM
585585
unicode-display_width (3.1.4)
586586
unicode-emoji (~> 4.0, >= 4.0.4)
587587
unicode-emoji (4.0.4)
588+
uri (0.13.1)
588589
useragent (0.16.11)
589590
vhd (0.0.4)
590591
bit-struct
@@ -608,9 +609,9 @@ PLATFORMS
608609
x86_64-linux
609610

610611
DEPENDENCIES
611-
actionpack (~> 7.2.2)
612-
actionview (~> 7.2.1)
613-
activemodel (~> 7.2.2)
612+
actionpack (~> 8.0.1)
613+
actionview (~> 8.0.1)
614+
activemodel (~> 8.0.1)
614615
addressable
615616
allowy (>= 2.1.0)
616617
azure-storage-blob!
@@ -660,7 +661,7 @@ DEPENDENCIES
660661
public_suffix
661662
puma
662663
rack-test
663-
railties (~> 7.2.1)
664+
railties (~> 8.0.1)
664665
rake
665666
redis
666667
roodi
@@ -693,6 +694,7 @@ DEPENDENCIES
693694
talentbox-delayed_job_sequel (~> 4.3.0)
694695
thin
695696
timecop
697+
uri (~> 0.13)
696698
vmstat (~> 2.3)
697699
webmock (> 2.3.1)
698700

config/application.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ class Application < Rails::Application
1717
Rails.autoloaders.main.ignore(Rails.root.join('app/**/*'))
1818

1919
config.active_support.cache_format_version = 7.0
20+
config.active_support.to_time_preserves_timezone = :zone
2021

2122
config.generators do |g|
2223
g.orm false

lib/cloud_controller/db.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -259,11 +259,3 @@ def self.logger
259259
end
260260
end
261261
end
262-
263-
if Rails::VERSION::MAJOR < 8
264-
module ActiveModel
265-
# rubocop:disable Lint/EmptyClass
266-
class ValidationContext; end
267-
# rubocop:enable Lint/EmptyClass
268-
end
269-
end

spec/unit/jobs/deserialization_spec.rb

Lines changed: 3 additions & 118 deletions
Original file line numberDiff line numberDiff line change
@@ -118,119 +118,7 @@ module Jobs
118118

119119
subject(:job) { SpaceApplyManifestActionJob.new(space, app_guid_message_hash, apply_manifest_action, user_audit_info) }
120120

121-
let(:serialized_job_rails_7) do
122-
<<~EOS
123-
--- !ruby/object:VCAP::CloudController::Jobs::LoggingContextJob
124-
handler: !ruby/object:VCAP::CloudController::Jobs::TimeoutJob
125-
handler: !ruby/object:VCAP::CloudController::Jobs::SpaceApplyManifestActionJob
126-
space: !ruby/object:VCAP::CloudController::Space
127-
values:
128-
:id: #{space.id}
129-
:guid: space-guid
130-
:created_at: #{space.created_at.strftime('%F %H:%M:%S.%9N Z')}
131-
:updated_at: #{space.updated_at.strftime('%F %H:%M:%S.%9N Z')}
132-
:name: space-name
133-
:organization_id: #{org.id}
134-
:space_quota_definition_id:#{' '}
135-
:allow_ssh: true
136-
:isolation_segment_guid:#{' '}
137-
app_guid_message_hash:
138-
app-guid: &1 !ruby/object:VCAP::CloudController::AppManifestMessage
139-
requested_keys:
140-
- :name
141-
- :instances
142-
- :routes
143-
- :buildpack
144-
- :stack
145-
extra_keys: []
146-
buildpack: ruby
147-
instances: 4
148-
name: app-name
149-
routes:
150-
- :route: app.bommel
151-
stack: cflinuxfs4
152-
original_yaml:
153-
:name: app-name
154-
:instances: 4
155-
:routes:
156-
- :route: app.bommel
157-
:buildpack: ruby
158-
:stack: cflinuxfs4
159-
validation_context:#{' '}
160-
errors: !ruby/object:ActiveModel::Errors
161-
base: *1
162-
errors: []
163-
manifest_process_scale_messages:
164-
- &2 !ruby/object:VCAP::CloudController::ManifestProcessScaleMessage
165-
requested_keys:
166-
- :instances
167-
- :type
168-
extra_keys: []
169-
instances: 4
170-
type: web
171-
validation_context:#{' '}
172-
errors: !ruby/object:ActiveModel::Errors
173-
base: *2
174-
errors: []
175-
manifest_process_update_messages: []
176-
app_update_message: &3 !ruby/object:VCAP::CloudController::AppUpdateMessage
177-
requested_keys:
178-
- :lifecycle
179-
extra_keys: []
180-
lifecycle:
181-
:data:
182-
:buildpacks:
183-
- ruby
184-
:stack: cflinuxfs4
185-
validation_context:#{' '}
186-
errors: !ruby/object:ActiveModel::Errors
187-
base: *3
188-
errors: []
189-
manifest_buildpack_message: &4 !ruby/object:VCAP::CloudController::ManifestBuildpackMessage
190-
requested_keys:
191-
- :buildpack
192-
extra_keys: []
193-
buildpack: ruby
194-
validation_context:#{' '}
195-
errors: !ruby/object:ActiveModel::Errors
196-
base: *4
197-
errors: []
198-
manifest_routes_update_message: &5 !ruby/object:VCAP::CloudController::ManifestRoutesUpdateMessage
199-
requested_keys:
200-
- :routes
201-
extra_keys: []
202-
routes:
203-
- :route: app.bommel
204-
validation_context:#{' '}
205-
errors: !ruby/object:ActiveModel::Errors
206-
base: *5
207-
errors: []
208-
manifest_route_mappings:
209-
- :route: !ruby/object:VCAP::CloudController::ManifestRoute
210-
attrs:
211-
:scheme: unspecified
212-
:user:#{' '}
213-
:password:#{' '}
214-
:host: app.bommel
215-
:port:#{' '}
216-
:path: ''
217-
:query:#{' '}
218-
:fragment:#{' '}
219-
:full_route: app.bommel
220-
:options: {}
221-
:protocol:#{' '}
222-
apply_manifest_action: !ruby/object:VCAP::CloudController::AppApplyManifest
223-
user_audit_info: &6 !ruby/object:VCAP::CloudController::UserAuditInfo
224-
user_email: [email protected]
225-
user_name: user-name
226-
user_guid: user-guid
227-
user_audit_info: *6
228-
timeout: 14400
229-
request_id:#{' '}
230-
EOS
231-
end
232-
233-
let(:serialized_job_rails_8) do
121+
let(:serialized_job) do
234122
<<~EOS
235123
--- !ruby/object:VCAP::CloudController::Jobs::LoggingContextJob
236124
handler: !ruby/object:VCAP::CloudController::Jobs::TimeoutJob
@@ -357,15 +245,12 @@ module Jobs
357245
ManifestBuildpackMessage, AppUpdateMessage, ManifestProcessScaleMessage, AppManifestMessage, Space, SpaceApplyManifestActionJob, TimeoutJob,
358246
LoggingContextJob]
359247
db_job = YAML.safe_load(jobs_in_db[0][:handler], permitted_classes: permitted_classes, aliases: true).as_json
360-
dumped_job = YAML.safe_load(Rails::VERSION::MAJOR >= 8 ? serialized_job_rails_8 : serialized_job_rails_7, permitted_classes: permitted_classes, aliases: true).as_json
248+
dumped_job = YAML.safe_load(serialized_job, permitted_classes: permitted_classes, aliases: true).as_json
361249
expect(db_job).to eq(dumped_job)
362250
end
363251

364252
it 'can be deserialized' do
365-
object = YAML.load_dj(serialized_job_rails_7)
366-
expect(object).not_to be_nil
367-
368-
object = YAML.load_dj(serialized_job_rails_8)
253+
object = YAML.load_dj(serialized_job)
369254
expect(object).not_to be_nil
370255
end
371256
end

spec/unit/lib/delayed_job/delayed_job_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
RSpec.describe 'delayed_job' do
22
describe 'version' do
33
it 'is not updated' do
4-
expect(Gem.loaded_specs['delayed_job'].version).to eq('4.1.12'),
4+
expect(Gem.loaded_specs['delayed_job'].version).to eq('4.1.13'),
55
'revisit monkey patch in lib/delayed_job/quit_trap.rb + review the changes related to lib/delayed_job/threaded_worker.rb'
66
end
77
end

0 commit comments

Comments
 (0)