Initial attempt at upgrading to Ruby 3.4

Author: sethboyles

.ruby-version

@@ -1 +1 @@
-3.3.5
+3.4.2

Gemfile

@@ -19,6 +19,7 @@ gem 'membrane', '~> 1.0'
 gem 'mime-types', '~> 3.6'
 gem 'mock_redis'
 gem 'multipart-parser'
+gem 'mutex_m'
 gem 'netaddr', '>= 2.0.4'
 gem 'net-ssh'
 gem 'newrelic_rpm'
@@ -39,10 +40,10 @@ gem 'sinatra-contrib'
 gem 'sshkey'
 gem 'statsd-ruby', '~> 1.5.0'
 gem 'steno'
+gem 'syslog'
 gem 'talentbox-delayed_job_sequel', '~> 4.3.0'
 gem 'thin'
 gem 'vmstat', '~> 2.3'
-
 # Rails Components
 gem 'actionpack', '~> 7.2.2'
 gem 'actionview', '~> 7.2.1'

Gemfile.lock

@@ -113,7 +113,7 @@ GEM
     base64 (0.2.0)
     beefcake (1.0.0)
     benchmark (0.3.0)
-    bigdecimal (3.1.8)
+    bigdecimal (3.1.9)
     bit-struct (0.17)
     builder (3.3.0)
     byebug (11.1.3)
@@ -330,6 +330,7 @@ GEM
     mustache (1.1.1)
     mustermann (3.0.0)
       ruby2_keywords (~> 0.0.1)
+    mutex_m (0.2.0)
     mysql2 (0.5.6)
     net-ssh (7.3.0)
     netaddr (2.0.6)
@@ -495,7 +496,7 @@ GEM
       sexp_processor (~> 4.1)
     rubyzip (2.3.2)
     securerandom (0.3.1)
-    sequel (5.85.0)
+    sequel (5.89.0)
       bigdecimal
     sequel_pg (1.17.1)
       pg (>= 0.18.0, != 1.2.0)
@@ -547,6 +548,7 @@ GEM
       fluent-logger
       yajl-ruby (~> 1.0)
     stringio (3.1.1)
+    syslog (0.1.1)
     talentbox-delayed_job_sequel (4.3.0)
       delayed_job (~> 4.1.0)
       sequel (>= 3.38, < 6.0)
@@ -621,6 +623,7 @@ DEPENDENCIES
   mime-types (~> 3.6)
   mock_redis
   multipart-parser
+  mutex_m
   mysql2 (~> 0.5.6)
   net-ssh
   netaddr (>= 2.0.4)
@@ -666,6 +669,7 @@ DEPENDENCIES
   sshkey
   statsd-ruby (~> 1.5.0)
   steno
+  syslog
   talentbox-delayed_job_sequel (~> 4.3.0)
   thin
   timecop

db/migrations/20220601183937_create_asg_lastest_updates.rb

@@ -1,7 +1,7 @@
 Sequel.migration do
   change do
     create_table :asg_timestamps do
-      primary_key name: :id
+      primary_key '{:name=>:id}'
       Timestamp :last_update
     end
   end

db/migrations/20221003231438_correct_asg_latest_update_id_column_name.rb

@@ -1,7 +1,7 @@
 Sequel.migration do
   change do
     alter_table :asg_timestamps do
-      rename_column :'{:name=>:id}', :id
+      rename_column '{:name=>:id}', :id
     end
   end
 end

spec/request/admin_actions_spec.rb

@@ -11,9 +11,9 @@
     let(:api_call) { ->(user_headers) { post '/v3/admin/actions/clear_buildpack_cache', {}, user_headers } }
 
     let(:expected_codes_and_responses) do
-      h = Hash.new(
-        code: 403
-      )
+      h = Hash.new({
+                     code: 403
+                   })
       h['admin'] = {
         code: 202
       }

spec/request/app_features_spec.rb

@@ -39,7 +39,7 @@
       end
 
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 404)
+        h = Hash.new({ code: 404 })
         %w[admin admin_read_only global_auditor space_developer space_manager space_auditor org_manager
            space_supporter].each do |r|
           h[r] = { code: 200, response_object: features_response_object }
@@ -57,7 +57,7 @@
 
   describe 'GET /v3/apps/:guid/features/:name' do
     let(:expected_codes_and_responses) do
-      h = Hash.new(code: 404)
+      h = Hash.new({ code: 404 })
       %w[admin admin_read_only global_auditor space_developer space_manager space_auditor org_manager
          space_supporter].each do |r|
         h[r] = { code: 200, response_object: feature_response_object }
@@ -114,9 +114,9 @@
       end
 
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
+        h = Hash.new({ code: 403, errors: CF_NOT_AUTHORIZED })
         %w[no_role org_auditor org_billing_manager].each { |r| h[r] = { code: 404 } }
-        %w[admin space_developer].each { |r| h[r] = { code: 200, response_object: feature_response_object } }
+        %w[admin space_devµeloper].each { |r| h[r] = { code: 200, response_object: feature_response_object } }
         h
       end
 
@@ -148,7 +148,7 @@
       end
 
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
+        h = Hash.new({ code: 403, errors: CF_NOT_AUTHORIZED })
         %w[no_role org_auditor org_billing_manager].each { |r| h[r] = { code: 404 } }
         %w[admin space_developer space_supporter].each do |r|
           h[r] = { code: 200, response_object: feature_response_object }

spec/request/app_manifests_spec.rb

@@ -58,7 +58,7 @@
     context 'permissions' do
       let(:api_call) { ->(user_headers) { get "/v3/apps/#{app_model.guid}/manifest", nil, user_headers } }
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 403)
+        h = Hash.new({ code: 403 })
         h['no_role'] = { code: 404 }
         h['org_auditor'] = { code: 404 }
         h['org_billing_manager'] = { code: 404 }

spec/request/app_usage_events_spec.rb

@@ -15,10 +15,10 @@
     let(:usage_event_json) { build_usage_event_json(usage_event) }
 
     let(:expected_codes_and_responses) do
-      h = Hash.new(
-        code: 404,
-        response_object: []
-      )
+      h = Hash.new({
+                     code: 404,
+                     response_object: []
+                   })
       h['admin'] = {
         code: 200,
         response_object: usage_event_json
@@ -62,10 +62,10 @@
     let(:app_usage_event_2_json) { build_usage_event_json(app_usage_event_2) }
 
     let(:expected_codes_and_responses) do
-      h = Hash.new(
-        code: 200,
-        response_objects: []
-      )
+      h = Hash.new({
+                     code: 200,
+                     response_objects: []
+                   })
       h['admin'] = {
         code: 200,
         response_objects: [app_usage_event_json, app_usage_event_2_json]
@@ -151,7 +151,7 @@
     end
 
     let(:expected_codes_and_responses) do
-      h = Hash.new(code: 403)
+      h = Hash.new({ code: 403 })
       h['admin'] = { code: 200 }
       h
     end

spec/request/apps_spec.rb

@@ -92,7 +92,7 @@
       end
 
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 403, errors: CF_NOT_AUTHORIZED)
+        h = Hash.new({ code: 403, errors: CF_NOT_AUTHORIZED })
         h['org_billing_manager'] = { code: 422 }
         h['org_auditor'] = { code: 422 }
         h['no_role'] = { code: 422 }
@@ -453,7 +453,7 @@
       end
 
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 200, response_objects: [app_model1_response_object, app_model2_response_object])
+        h = Hash.new({ code: 200, response_objects: [app_model1_response_object, app_model2_response_object] })
 
         h['org_auditor'] = {
           code: 200,
@@ -1359,7 +1359,7 @@
       end
 
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 200, response_object: app_model_response_object)
+        h = Hash.new({ code: 200, response_object: app_model_response_object })
         h['org_auditor'] = { code: 404 }
         h['org_billing_manager'] = { code: 404 }
         h['no_role'] = { code: 404 }
@@ -1593,7 +1593,7 @@
       end
 
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 200, response_object: app_model_response_object)
+        h = Hash.new({ code: 200, response_object: app_model_response_object })
         h['space_supporter'] = { code: 200, response_object: app_model_empty_system_env_response_object }
         h['global_auditor'] = h['org_manager'] = h['space_manager'] = h['space_auditor'] = { code: 403 }
         h['org_auditor'] = h['org_billing_manager'] = h['no_role'] = { code: 404 }
@@ -1725,7 +1725,7 @@
       end
 
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 403)
+        h = Hash.new({ code: 403 })
         h['admin'] = h['admin_read_only'] = h['space_developer'] = { code: 200, response_object: expected_response }
         h['space_supporter'] = { code: 200, response_object: expected_response_system_env_redacted }
         h['org_auditor'] = h['org_billing_manager'] = h['no_role'] = { code: 404 }
@@ -1741,7 +1741,7 @@
 
         it_behaves_like 'permissions for single object endpoint', ALL_PERMISSIONS do
           let(:expected_codes_and_responses) do
-            h = Hash.new(code: 403)
+            h = Hash.new({ code: 403 })
             h['admin'] = h['admin_read_only'] = { code: 200, response_object: expected_response }
             h['org_auditor'] = h['org_billing_manager'] = h['no_role'] = { code: 404 }
             h
@@ -1810,7 +1810,7 @@
         ->(headers) { get "/v3/apps/#{app_model.guid}/builds", nil, headers }
       end
       let(:expected_codes_and_responses) do
-        h = Hash.new(code: 200, response_guids: [build.guid, second_build.guid])
+        h = Hash.new({ code: 200, response_guids: [build.guid, second_build.guid] })
         h['org_auditor'] = { code: 404 }
         h['org_billing_manager'] = { code: 404 }
         h['no_role'] = { code: 404 }