Remove not needed checks

Author: gururajsh

lib/cloud_controller/check_stacks.rb

@@ -23,7 +23,7 @@ def validate_stack(deprecated_stack)
       return if deprecated_stack_in_config
 
       deprecated_stack_in_db = false
-      @db.fetch('SELECT * FROM stacks WHERE name LIKE ? ', deprecated_stack) do |_row|
+      @db.fetch('SELECT 1 FROM stacks WHERE name LIKE ? ', deprecated_stack) do |_row|
         deprecated_stack_in_db = true
       end
       raise "rake task 'stack_check' failed, stack '#{deprecated_stack}' not supported" if deprecated_stack_in_db

lib/tasks/stack_check.rake

@@ -4,9 +4,7 @@ namespace :stacks do
     logger = Steno.logger('cc.stack')
     db = VCAP::CloudController::DB.connect(RakeConfig.config.get(:db), logger)
     next unless db.table_exists?(:stacks)
-    next unless db.table_exists?(:buildpack_lifecycle_data)
 
-    RakeConfig.config.load_db_encryption_key
     require 'models/helpers/stack_config_file'
     require 'cloud_controller/check_stacks'
     VCAP::CloudController::CheckStacks.new(RakeConfig.config, db).validate_stacks

spec/tasks/stack_check_spec.rb

@@ -52,34 +52,7 @@
       before do
         allow(db_double).to receive(:table_exists?).with(:stacks).and_return true
         allow(VCAP::CloudController::DB).to receive(:connect).and_return(db_double)
-        allow(db_double).to receive(:fetch).with('SELECT * FROM stacks WHERE name LIKE ? ', 'cflinuxfs3').and_return('1')
-      end
-
-      it 'validates stacks' do
-        expect_any_instance_of(VCAP::CloudController::CheckStacks).to receive(:validate_stacks).and_call_original
-        Rake::Task['stacks:stack_check'].execute
-      end
-    end
-  end
-
-  context 'buildpack_lifecycle_data' do
-    context 'when buildpack_lifecycle_data table doesnt exist' do
-      before do
-        allow(db_double).to receive(:table_exists?).with(:buildpack_lifecycle_data).and_return false
-        allow(VCAP::CloudController::DB).to receive(:connect).and_return(db_double)
-      end
-
-      it 'does nothing' do
-        expect_any_instance_of(VCAP::CloudController::CheckStacks).not_to receive(:validate_stacks)
-        Rake::Task['stacks:stack_check'].execute
-      end
-    end
-
-    context 'when buildpack_lifecycle_data table does exist' do
-      before do
-        allow(double).to receive(:table_exists?).with(:buildpack_lifecycle_data).and_return true
-        allow(VCAP::CloudController::DB).to receive(:connect).and_return(db_double)
-        allow(db_double).to receive(:fetch).with('SELECT * FROM stacks WHERE name LIKE ? ', 'cflinuxfs3').and_return('1')
+        allow(db_double).to receive(:fetch).with('SELECT 1 FROM stacks WHERE name LIKE ? ', 'cflinuxfs3').and_return('1')
       end
 
       it 'validates stacks' do