Remove mysql 5.7 from unit tests #4018
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- mysql 5.7 is explicitly not supported for [cf-deployment|https://github.com/cloudfoundry/cf-deployment/blob/main/texts/deployment-guide.md#databases] - fixes #3949 and unblocks #3952
|
Our preference would be to hold off on this until May, as we support foundations using MySQL 5.7 until then. |
|
OK, we need then to adapt #3949 to work with mysql 5.7. |
|
Our support date for MySQL 5.7 is actually |
|
@sethboyles @Samze Can we proceed on this? |
|
Yes, please go ahead. |
|
(and thank you for your patience) |
johha
approved these changes
Aug 21, 2025
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 21, 2025
Changes in cloud_controller_ng:
- Remove mysql 5.7 from unit tests
PR: cloudfoundry/cloud_controller_ng#4018
Author: Stephan Merker <[email protected]>
Gerg
pushed a commit
that referenced
this pull request
Aug 27, 2025
- mysql 5.7 is explicitly not supported for [cf-deployment|https://github.com/cloudfoundry/cf-deployment/blob/main/texts/deployment-guide.md#databases] - fixes #3949 and unblocks #3952
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Take out mysql 5.7 from the unit test matrix as it is explicitly not supported for cf-deployment.
Allows to use mysql features and rely on bug fixes that are not available in mysql 5.7.
Example: Dropping of duplicated unique constraints in DB migrations.
Fixes #3949 and unblocks #3952
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests