Skip to content

Fix flaky timecop specs #4461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix flaky timecop specs #4461

wants to merge 1 commit into from

Conversation

philippthun
Copy link
Member

@philippthun philippthun commented Jul 21, 2025 •
edited
Loading

  • ensure nested Timecop calls get returned in ServiceInstanceStateFetch specs
  • wrap stubbed time freeze in ResourceMatch specs
  • use around block for consistent time in DeploymentModel specs
  • close Timecop travel blocks in DistributedExecutor specs

@philippthun philippthun marked this pull request as draft July 21, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@philippthun