You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: toc/rfc/rfc-formal-aspiring-approvers-as-reviewers.md
+33Lines changed: 33 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -39,3 +39,36 @@ This extends [RFC-005 Standardizing Github Teams and Access](https://github.com/
39
39
Where:
40
40
*`WORKING-GROUP-NAME` is the name of the Working Group, converted to kebab case,
41
41
*`AREA-NAME` is the name of the area, also converted to kebab case, or a suitable short name that identifies it clearly and uniquely within the Working Group.
42
+
43
+
[RFC-008 Role Change Process](https://github.com/cloudfoundry/community/blob/main/toc/rfc/rfc-0008-role-change-process.md) gets extended as well:
44
+
45
+
### Promotion to Reviewer
46
+
47
+
- When a contributor wishes to get a Reviewer for a Working Group area,
48
+
they may submit a PR to the appropriate Working Group Charter that adds
49
+
themselves to the team's yaml definition.
50
+
51
+
- Two existing Approvers for that Working Group must support the promotion by reviewing the PR.
52
+
There are no specific criteria beside being a contributor.
53
+
54
+
- For Working Groups with fewer than 4 approvers, a single Approver review is
55
+
sufficient.
56
+
57
+
- An existing Approver may submit the promotion request on behalf of someone else, but they
58
+
may not serve as a reviewer.
59
+
60
+
- A Working Group Lead for that Working Group will merge or close the PR, based
61
+
on the results of the review and their discretion.
62
+
63
+
- TOC members may bypass the review process and merge the PR at their
64
+
discretion.
65
+
66
+
### Revoking Reviewer Role
67
+
68
+
- People with an Reviewer role may submit a PR to revoke their role by removing the appropriate entry from the yaml definition in their Working Group's charter.
69
+
70
+
- An existing Approver may submit the revocation request on behalf of someone else, but the person whose role is being revoked must be given two weeks to refute the revocation.
71
+
72
+
- A Working Group Lead for that Working Group will merge or close the PR, at their discretion and without review.
73
+
74
+
- TOC members may merge the PR at their discretion.
0 commit comments