Skip to content

Commit 05d957b

Browse files
committed
Update logging/app events and rolling deploy information
1 parent 41b96f7 commit 05d957b

File tree

1 file changed

+15
-2
lines changed

1 file changed

+15
-2
lines changed

toc/rfc/rfc-draft-readiness-healthchecks.md

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,11 @@ The "process" healthcheck type will not be supported since it doesn't make sense
4848
to have "process" readiness healthcheck type. Once any defined process exits AI
4949
is marked as crashed.
5050

51+
## Rolling deploys
52+
53+
Rolling deploys should take into account the AI routable status. Old AI should
54+
be replaced with the new once new is running and routable.
55+
5156
### Architecture Overview
5257
This feature will require changes in the following releases
5358

@@ -112,14 +117,22 @@ The readiness healthcheck data will be apart of the desired LRP object.
112117
},
113118
```
114119

115-
### Logging
120+
### Logging and Metrics
121+
122+
#### App logs
116123

117124
When AI readiness healthcheck succeeds a log line is printed to AI logs:
118125
"Container became ready". When AI readiness healthcheck fails a log line is
119126
printed to AI logs: "Container became not ready".
120127

128+
#### App events
129+
130+
When AI readiness healthcheck succeeds a new application event is emitted:
131+
"app.ready". When AI readiness healthcheck fails a new event is emitted:
132+
"app.notready".
133+
121134
### Open Questions
122-
* What metrics or events would be helpful for app devs and operators?
135+
* What metrics would be helpful for app devs and operators?
123136

124137
This work is ongoing. All comments and concerns are welcomed from the community.
125138
Either add a comment here or reach out in slack in #wg-app-runtime-platform.

0 commit comments

Comments
 (0)