Skip to content

Commit 380127d

Browse files
authored
Update readiness healthcheck RFC
* add interval property * add process type for backwards compatibility
1 parent 5834ae8 commit 380127d

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

toc/rfc/rfc-draft-readiness-healthchecks.md

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -41,12 +41,9 @@ than the current option.
4141

4242
## Types of readiness healthcheck
4343

44-
Readiness healthcheck can be either "http" or "port" type. The format of healthcheck
45-
type is [similar to liveness
46-
healthcheck](https://docs.cloudfoundry.org/devguide/deploy-apps/healthchecks.html).
47-
The "process" healthcheck type will not be supported since it doesn't make sense
48-
to have "process" readiness healthcheck type. Once any defined process exits AI
49-
is marked as crashed.
44+
[Similar to liveness healthchecks](https://docs.cloudfoundry.org/devguide/deploy-apps/healthchecks.html), readiness healthcheck can be of type "http", "port", or "process".
45+
However, when a user selects the "process" healthcheck type, nothing will be passed to the LRP, because once a process exits the AI
46+
is marked as crashed and Diego will attempt a restart. The default readiness healthcheck type is "process", which is backwards compatible.
5047

5148
## Rolling deploys
5249

@@ -88,6 +85,7 @@ applications:
8885
readiness-health-check-http-endpoint: /ready # 👈 new property
8986
readiness-health-check-invocation-timeout: 2 # 👈 new property
9087
readiness-health-check-type: http # 👈 new property
88+
readiness-health-check-interval: 5 # 👈 new property
9189
```
9290

9391
New `routable` field in CC API [process stats
@@ -135,10 +133,12 @@ CF CLI `cf app` output.
135133

136134
New CLI options will be added to `cf push` command:
137135

138-
* `--readiness-endpoint` will allows to set the endpoint for http readiness
136+
* `--readiness-endpoint` will set the endpoint for http readiness
139137
checks.
140-
* `--readiness-health-check-type` will allows to set the type of the readiness
141-
check: "http" or "port".
138+
* `--readiness-health-check-type` will set the type of the readiness
139+
check: "http", "port", or "process".
140+
* `--readiness-health-check-interval` will set the interval of the readiness
141+
check. Must be an integer greater than 0."
142142

143143
New CLI commands will be added:
144144

0 commit comments

Comments
 (0)