@@ -253,16 +253,11 @@ in.
253
253
254
254
A reviewer is an active contributor who wishes to formally work toward the approver role.
255
255
256
- Reviewers can submit reviews of PRs within a working group area . They may also have PRs within a working group assigned to them.
256
+ Reviewers can submit reviews of PRs within a Working Group Area . They may also have PRs within a working group assigned to them.
257
257
258
258
### Requirements
259
259
260
- - Submission of a PR to the appropriate Working Group Charter that adds themselves to the team's yaml definition.
261
-
262
- - Approval from two existing Approvers for that Working Group
263
-
264
- - For Working Groups with fewer than 4 approvers, a single Approver review is sufficient.
265
-
260
+ - Actively contributing to the relevant Working Group Area(s).
266
261
267
262
### Responsibilities and privileges
268
263
@@ -492,33 +487,34 @@ Last ammended by [RFC-0008 Role Change Process](https://github.com/cloudfoundry/
492
487
they may submit a PR adding themselves to
493
488
[ contributors.yml] ( https://github.com/cloudfoundry/community/blob/main/org/contributors.yml ) .
494
489
495
- - Two existing Contributors or Approvers must attest that they meet the criteria
496
- by reviewing the PR.
490
+ - Two existing Contributors, Reviewers, or Approvers must attest that they meet
491
+ the criteria by reviewing the PR.
497
492
498
- - An existing Contributor or Approver may submit the promotion request on behalf of someone else, but they
499
- may not serve as a reviewer.
493
+ - An existing Contributor, Reviewer, or Approver may submit the promotion
494
+ request on behalf of someone else, but they may not serve as a reviewer.
500
495
501
496
- A Working Group Lead from any Working Group will merge or close the PR, based
502
497
on the results of the review and their discretion.
503
498
504
499
- TOC members may bypass the review process and merge the PR at their
505
500
discretion.
506
501
507
- ### Promotion to Approver
502
+ ### Promotion to Reviewer or Approver
508
503
509
- - When a person meets the criteria to be an Approver for a Working Group as defined in
510
- [ Approver Role] ( #approver ) ,
511
- they may submit a PR to the appropriate Working Group Charter that adds
512
- themselves to the team's yaml definition.
504
+ - When a person meets the criteria to be a Reviewer or Approver for a Working
505
+ Group Area as defined in [ Reviewer Role] ( #reviewer ) or [ Approver
506
+ Role] ( #approver ) respectively, they may submit a PR to the appropriate
507
+ Working Group Charter that adds themselves to the team's yaml definition
508
+ under the appropriate Area.
513
509
514
- - Two existing Approvers for that Working Group must attest that they meet the criteria
515
- by reviewing the PR.
510
+ - Two existing Approvers for that Working Group Area must attest that they meet
511
+ the criteria by reviewing the PR.
516
512
517
- - For Working Groups with fewer than 4 approvers , a single Approver review is
518
- sufficient.
513
+ - For Working Group Areas with fewer than 4 Approvers , a single Approver review
514
+ is sufficient.
519
515
520
- - An existing Approver may submit the promotion request on behalf of someone else, but they
521
- may not serve as a reviewer.
516
+ - An existing Approver may submit the promotion request on behalf of someone
517
+ else, but they may not serve as a reviewer.
522
518
523
519
- A Working Group Lead for that Working Group will merge or close the PR, based
524
520
on the results of the review and their discretion.
@@ -532,19 +528,20 @@ themselves to the team's yaml definition.
532
528
removing the appropriate entry from
533
529
[ contributors.yml] ( https://github.com/cloudfoundry/community/blob/main/org/contributors.yml ) .
534
530
535
- - An existing Contributor or Approver may submit the revocation request on
536
- behalf of someone else, but the person whose role is being revoked must be
537
- given two weeks to refute the revocation.
531
+ - An existing Contributor, Reviewer, or Approver may submit the revocation
532
+ request on behalf of someone else, but the person whose role is being revoked
533
+ must be given two weeks to refute the revocation.
538
534
539
535
- A Working Group Lead from any Working Group will merge or close the PR, at
540
536
their discretion and without review.
541
537
542
538
- TOC members may merge the PR at their discretion.
543
539
544
- ### Revoking Approver Role
540
+ ### Revoking Reviewer or Approver Role
545
541
546
- - People with an Approver role may submit a PR to revoke their role by removing
547
- the appropriate entry from the yaml definition in their Working Group's charter.
542
+ - People with a Reviewer or Approver role may submit a PR to revoke their role
543
+ by removing the appropriate entry from the yaml definition in their Working
544
+ Group's charter.
548
545
549
546
- An existing Approver may submit the revocation request on behalf of someone
550
547
else, but the person whose role is being revoked must be given two weeks to
0 commit comments