Skip to content

Commit 6819860

Browse files
committed
Refer to application instance when applicable
1 parent d24c093 commit 6819860

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

toc/rfc/rfc-draft-readiness-healthchecks.md

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,15 @@
1010
## Summary
1111

1212
Add a readiness healthcheck option for apps. When the readiness healthcheck
13-
passes, the app is marked "ready" and the app will be routable. When the
14-
readiness healthcheck fails, the app is marked as "not ready" and its route will
15-
be removed from gorouter's route table.
13+
passes, the app instance (AI) is marked "ready" and the AI will be routable.
14+
When the readiness healthcheck fails, the AI is marked as "not ready" and its
15+
route will be removed from gorouter's route table.
1616

1717
## Problem
1818

1919
With the current implementation of application healthchecks, when the
20-
application healthcheck detects that an app instance (AI) is unhealthy, then
21-
Diego will stop the AI, delete the AI, and reschedule a new AI.
20+
application healthcheck detects that an AI is unhealthy, then Diego will stop
21+
the AI, delete the AI, and reschedule a new AI.
2222

2323
This is too aggressive from some apps. There could be many reasons why a single
2424
request could fail, but the app is actually running fine. Additionally, many
@@ -33,11 +33,11 @@ the app should be kept alive, but in a non-routable state.
3333
We intend to support readiness healthchecks. (This was requested previously in
3434
this [issue](https://github.com/cloudfoundry/cloud_controller_ng/issues/1706).)
3535
This would be an additional healthcheck that app developers could configure.
36-
When the readiness healthcheck passes, the app is marked "ready" and the app
37-
will be routable. When the readiness healthcheck fails, the app is marked as
38-
"not ready" and its route will be removed from gorouter's route table.
39-
This new readiness healthcheck will give users a healthcheck option that is less
40-
drastic than the current option.
36+
When the readiness healthcheck passes, the AI is marked "ready" and the AI will
37+
be routable. When the readiness healthcheck fails, the AI is marked as "not
38+
ready" and its route will be removed from gorouter's route table. This new
39+
readiness healthcheck will give users a healthcheck option that is less drastic
40+
than the current option.
4141

4242
### Architecture Overview
4343
This feature will require changes in the following releases
@@ -52,12 +52,12 @@ This feature will require changes in the following releases
5252
2. The Diego executor will see these new readiness healthchecks on the desired
5353
LRP and will run the healthchecker binary in the app container with
5454
configuration provided.
55-
3. When the readiness healthcheck succeeds, the container will be marked as
56-
"ready". When the readiness healthcheck fails, the container will be marked
55+
3. When the readiness healthcheck succeeds, the actual LRP will be marked as
56+
"ready". When the readiness healthcheck fails, the actual LRP will be marked
5757
as "not ready".
5858
4. When the route emitter gets route information, it will inspect if the AI is
5959
ready or not ready. It will emit registration or unregistration messages as
60-
appropriate for the gorouter to consume
60+
appropriate for the gorouter to consume.
6161

6262
### CC Design
6363
Users will be able to set the healthcheck via the app manifest.

0 commit comments

Comments
 (0)