Skip to content

Commit a15faf5

Browse files
committed
Apply review feedback
1 parent 8966a9d commit a15faf5

File tree

1 file changed

+10
-10
lines changed

1 file changed

+10
-10
lines changed

toc/rfc/rfc-draft-hash-based-routing.md

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ that it remaps hashes associated with the app_instance3:
9292
#### Considering a balance factor
9393

9494
Before routing a request, the current load on each application instance must be evaluated using a balance factor. This
95-
load is measured by the number of in-flight requests. For example, with a balance factor of 150, no application instance
95+
load is measured by the number of in-flight requests. For example, with a balance factor of 1.5, no application instance
9696
should exceed 150% of the average number of in-flight requests across all application instances. Consequently, requests
9797
must be distributed to different application instances that are not overloaded.
9898

@@ -129,7 +129,7 @@ A possible presentation of deterministic handling can be a ring like:
129129
particular route to consider overload situations
130130
- Gorouter MUST update its local hash table following the registration or deregistration of an endpoint, ensuring
131131
minimal rehashing
132-
- Gorouter SHOULD NOT not incur any performance hit when 0 apps use hash routing.
132+
- Gorouter SHOULD NOT incur any performance hit when 0 apps use hash routing.
133133

134134
For a detailed understanding of the workflows on Gorouter's side, please refer to the [activity diagrams](#diagrams).
135135

@@ -143,9 +143,9 @@ For a detailed understanding of the workflows on Gorouter's side, please refer t
143143
and the balance factor
144144
- It MUST implement the validation of the following requirements:
145145
- The `hash_header` property is mandatory when load balancing is set to hash
146-
- The `hash_balance` property is optional when load balancing is set to hash. Leaving out `hash_balance` means the
147-
load situation will not be considered
148-
- To account for overload situations, `hash_balance` values should be greater than 110. During the implementation
146+
- The `hash_balance` property is optional when load balancing is set to hash. Leaving out `hash_balance` or setting
147+
it explicitly to 0 means the load situation will not be considered
148+
- To account for overload situations, `hash_balance` values should be greater than 1.1. During the implementation
149149
phase, the values will be evaluated to identify the best fit for the recommended range
150150
- For load balancing algorithms other than hash, the `hash_balance` and `hash_header` properties MUST not be set
151151

@@ -160,7 +160,7 @@ applications:
160160
options:
161161
loadbalancing: hash
162162
hash_header: tenant-id
163-
hash_balance: 125
163+
hash_balance: 1.25
164164
- route: anothertest.example.com
165165
options:
166166
loadbalancing: least-connection
@@ -186,11 +186,11 @@ proposed properties.
186186
Example:
187187

188188
```bash
189-
cf create-route MY-APP example.com -n test -o loadbalancing=hash -o hash_header=tenant-id -o hash_balance=125
190-
cf update-route MY-APP example.com -n test -o loadbalancing=hash -o hash_header=tenant-id -o hash_balance=125
189+
cf create-route MY-APP example.com -n test -o loadbalancing=hash -o hash_header=tenant-id -o hash_balance=1.25
190+
cf update-route MY-APP example.com -n test -o loadbalancing=hash -o hash_header=tenant-id -o hash_balance=1.25
191191
cf update-route MY-APP example.com -n test -o loadbalancing=hash -o hash_header=tenant-id
192-
cf update-route MY-APP example.com -n test -o loadbalancing=hash -o hash_balance=125
193-
cf map-route MY-APP example.com -n test -o loadbalancing=hash -o hash_header=tenant-id -o hash_balance=125
192+
cf update-route MY-APP example.com -n test -o loadbalancing=hash -o hash_balance=1.25
193+
cf map-route MY-APP example.com -n test -o loadbalancing=hash -o hash_header=tenant-id -o hash_balance=1.25
194194
```
195195

196196
#### Route-Emitter

0 commit comments

Comments
 (0)