Skip to content

Commit d0d4029

Browse files
committed
rfc: specify failure mode
1 parent 558de78 commit d0d4029

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

toc/rfc/rfc-draft-generic-per-route-features.md

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,10 @@ components.
8585
8686
Gorouter MUST accept the new field and parse its contents. If the map cannot be parsed it MUST
8787
be ignored. If individual key-value pairs are invalid those MUST be ignored and other key-value
88-
pairs MUST still be parsed and acted upon.
88+
pairs MUST still be parsed and acted upon. For any option which could not be parsed gorouter MUST
89+
NOT fail but fall back to the value provided in the gorouter config. When encountering an invalid
90+
option gorouter MUST log the error at least once, the log SHOULD indicate what it tried to parse,
91+
why it failed and which value will come into effect.
8992
9093
It MAY be decided to implement one feature as part of this RFC which would be implemented together
9194
with the generic logic for supporting the new map.

0 commit comments

Comments
 (0)