Skip to content

Commit c191459

Browse files
kart2bcgeofffranks
authored andcommitted
add seconds as unit for timeout setting
1 parent 9d6d317 commit c191459

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

jobs/bbs/spec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -103,13 +103,13 @@ properties:
103103
default: 200
104104
diego.bbs.sql.db_connection_timeout:
105105
description: "Timeout in seconds for a db client to wait for a connection to be established"
106-
default: "30s"
106+
default: "30"
107107
diego.bbs.sql.db_read_timeout:
108108
description: "Timeout in seconds for a db client to wait for data to be received from the server"
109-
default: "600s"
109+
default: "600"
110110
diego.bbs.sql.db_write_timeout:
111111
description: "Timeout in seconds for a db client to wait for data to be sent to the server"
112-
default: "600s"
112+
default: "600"
113113
diego.bbs.sql.require_ssl:
114114
description: "Whether to require SSL for BBS communication to the SQL backend"
115115
default: false

spec/bbs_template_spec.rb

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,9 @@
9494

9595
describe 'Database timeout configurations' do
9696
it 'includes db timeout settings when specified' do
97-
deployment_manifest_fragment['diego']['bbs']['sql']['db_connection_timeout'] = '30s'
98-
deployment_manifest_fragment['diego']['bbs']['sql']['db_read_timeout'] = '60s'
99-
deployment_manifest_fragment['diego']['bbs']['sql']['db_write_timeout'] = '45s'
97+
deployment_manifest_fragment['diego']['bbs']['sql']['db_connection_timeout'] = '30'
98+
deployment_manifest_fragment['diego']['bbs']['sql']['db_read_timeout'] = '60'
99+
deployment_manifest_fragment['diego']['bbs']['sql']['db_write_timeout'] = '45'
100100
rendered_template_json = JSON.parse(rendered_template)
101101
expect(rendered_template_json['db_connection_timeout']).to eq('30s')
102102
expect(rendered_template_json['db_read_timeout']).to eq('60s')

0 commit comments

Comments
 (0)