Add lifecycle support in the manifest structure

Author: mogul

operation/manifest.go

@@ -27,6 +27,14 @@ const (
 	TCP   AppRouteProtocol = "tcp"
 )
 
+type AppLifecycle string
+
+const (
+	Buildpack AppLifecycle = "buildpack"
+	Docker    AppLifecycle = "docker"
+	CNB       AppLifecycle = "cnb"
+)
+
 type Manifest struct {
 	Version      string         `yaml:"version,omitempty"`
 	Applications []*AppManifest `yaml:"applications"`
@@ -37,6 +45,7 @@ type AppManifest struct {
 	Path               string                `yaml:"path,omitempty"`
 	Buildpacks         []string              `yaml:"buildpacks,omitempty"`
 	Docker             *AppManifestDocker    `yaml:"docker,omitempty"`
+	Lifecycle          AppLifecycle          `yaml:"lifecycle,omitempty"`
 	Env                map[string]string     `yaml:"env,omitempty"`
 	RandomRoute        bool                  `yaml:"random-route,omitempty"`
 	NoRoute            bool                  `yaml:"no-route,omitempty"`

operation/manifest_test.go

@@ -140,3 +140,103 @@ func TestManifestUnMarshalling(t *testing.T) {
 	require.Equal(t, 1, len(m.Applications))
 	require.Equal(t, 2, len(*m.Applications[0].Services))
 }
+
+func TestManifestLifecycle(t *testing.T) {
+	t.Run("Marshall with buildpack lifecycle", func(t *testing.T) {
+		m := &Manifest{
+			Applications: []*AppManifest{
+				{
+					Name:      "test-app",
+					Lifecycle: Buildpack,
+				},
+			},
+		}
+		b, err := yaml.Marshal(&m)
+		require.NoError(t, err)
+		require.Contains(t, string(b), "lifecycle: buildpack")
+	})
+
+	t.Run("Marshall with docker lifecycle", func(t *testing.T) {
+		m := &Manifest{
+			Applications: []*AppManifest{
+				{
+					Name:      "test-app",
+					Lifecycle: Docker,
+				},
+			},
+		}
+		b, err := yaml.Marshal(&m)
+		require.NoError(t, err)
+		require.Contains(t, string(b), "lifecycle: docker")
+	})
+
+	t.Run("Marshall with cnb lifecycle", func(t *testing.T) {
+		m := &Manifest{
+			Applications: []*AppManifest{
+				{
+					Name:      "test-app",
+					Lifecycle: CNB,
+				},
+			},
+		}
+		b, err := yaml.Marshal(&m)
+		require.NoError(t, err)
+		require.Contains(t, string(b), "lifecycle: cnb")
+	})
+
+	t.Run("Marshall without lifecycle (omitempty)", func(t *testing.T) {
+		m := &Manifest{
+			Applications: []*AppManifest{
+				{
+					Name: "test-app",
+				},
+			},
+		}
+		b, err := yaml.Marshal(&m)
+		require.NoError(t, err)
+		require.NotContains(t, string(b), "lifecycle:")
+	})
+
+	t.Run("Unmarshall with buildpack lifecycle", func(t *testing.T) {
+		yamlData := `applications:
+- name: test-app
+  lifecycle: buildpack`
+
+		var m Manifest
+		err := yaml.Unmarshal([]byte(yamlData), &m)
+		require.NoError(t, err)
+		require.Equal(t, Buildpack, m.Applications[0].Lifecycle)
+	})
+
+	t.Run("Unmarshall with docker lifecycle", func(t *testing.T) {
+		yamlData := `applications:
+- name: test-app
+  lifecycle: docker`
+
+		var m Manifest
+		err := yaml.Unmarshal([]byte(yamlData), &m)
+		require.NoError(t, err)
+		require.Equal(t, Docker, m.Applications[0].Lifecycle)
+	})
+
+	t.Run("Unmarshall with cnb lifecycle", func(t *testing.T) {
+		yamlData := `applications:
+- name: test-app
+  lifecycle: cnb`
+
+		var m Manifest
+		err := yaml.Unmarshal([]byte(yamlData), &m)
+		require.NoError(t, err)
+		require.Equal(t, CNB, m.Applications[0].Lifecycle)
+	})
+
+	t.Run("Unmarshall without lifecycle (empty)", func(t *testing.T) {
+		yamlData := `applications:
+- name: test-app`
+
+		var m Manifest
+		err := yaml.Unmarshal([]byte(yamlData), &m)
+		require.NoError(t, err)
+		require.Equal(t, AppLifecycle(""), m.Applications[0].Lifecycle)
+	})
+}