Polishing

[resolves #784]

Signed-off-by: Ben Hale <[email protected]>

Author: nebhale

lib/java_buildpack/framework/riverbed_appinternals_agent.rb

@@ -18,30 +18,17 @@
 require 'fileutils'
 require 'java_buildpack/component/versioned_dependency_component'
 require 'java_buildpack/framework'
+
 module JavaBuildpack
   module Framework
 
     # Encapsulates the functionality for running the Riverbed Appinternals Agent support.
     class RiverbedAppinternalsAgent < JavaBuildpack::Component::VersionedDependencyComponent
 
-      # Creates an instance
-      #
-      # @param [Hash] context a collection of utilities used the component
-      def initialize(context)
-        super(context)
-###        @uri = download_url(credentials, @uri)
-      end
-
       # (see JavaBuildpack::Component::BaseComponent#compile)
       def compile
-###        JavaBuildpack::Util::Cache::InternetAvailability.instance.available(
-###          true, 'Downloading from Riverbed AppInternals Service Broker'
-###        ) do
-          download_zip(false, @droplet.sandbox, @component_name)
-###        end
+        download_zip(false, @droplet.sandbox, @component_name)
         @droplet.copy_resources
-###      rescue StandardError => e
-###        raise "Riverbed AppInternals download failed: #{e}"
       end
 
       # (see JavaBuildpack::Component::BaseComponent#release)
@@ -69,8 +56,6 @@ def supports?
 
       private
 
-      PROFILERURL = 'profilerUrlLinux'
-
       FILTER = /appinternals/.freeze
 
       private_constant :FILTER
@@ -107,10 +92,6 @@ def rvbd_moniker(credentials)
         credentials['rvbd_moniker'] || @configuration['rvbd_moniker']
       end
 
-###      def download_url(credentials, default_url)
-###        (credentials[PROFILERURL] unless credentials.nil?) || default_url
-###      end
-
     end
   end
 end

spec/java_buildpack/framework/riverbed_appinternals_agent_spec.rb

@@ -31,9 +31,6 @@
     before do
       allow(services).to receive(:one_service?).with(/appinternals/).and_return(true)
 
-###      allow(services).to receive(:find_service).and_return('credentials' => { 'profilerUrlLinux' =>
-###                                                                                'http://testfoobar/profiler.zip' })
-
       allow(application_cache).to receive(:get).with('http://testfoobar/profiler.zip')
                                                .and_yield(Pathname.new('spec/fixtures/'\
                                                'stub-riverbed-appinternals-agent.zip').open, false)