Polishing

[resolves #789]

Signed-off-by: Ben Hale <[email protected]>

Author: nebhale

.rubocop.yml

@@ -18,7 +18,7 @@ Layout/EmptyLinesAroundModuleBody:
 Layout/MultilineOperationIndentation:
   Enabled: false
 Metrics/AbcSize:
- Max: 22
+ Max: 25
 Metrics/BlockLength:
   Exclude:
   - 'spec/**/*.rb'

lib/java_buildpack/framework/java_memory_assistant/agent.rb

@@ -47,7 +47,7 @@ def release
           # Java modules limitations in Java 9+
           # See https://github.com/SAP/java-memory-assistant#running-the-java-memory-assistant-on-java-11
           @droplet.java_opts
-                .add_preformatted_options('--add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED')
+                  .add_preformatted_options('--add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED')
         end
 
         add_system_prop_if_config_present 'check_interval', 'jma.check_interval'
@@ -59,7 +59,7 @@ def release
         return unless @configuration.key?('thresholds')
 
         @configuration['thresholds'].each do |key, value|
-          @droplet.java_opts.add_preformatted_options "'-Djma.thresholds.#{key}=#{value.to_s}'"
+          @droplet.java_opts.add_preformatted_options "'-Djma.thresholds.#{key}=#{value}'"
         end
       end
 

spec/java_buildpack/framework/java_memory_assistant/agent_spec.rb

@@ -72,13 +72,13 @@
         delegate         = JavaBuildpack::Component::MutableJavaHome.new
         delegate.root    = app_dir + '.test-java-home'
         delegate.version = JavaBuildpack::Util::TokenizedVersion.new('1.8.0_55')
-    
+
         delegate
       end
 
-      it 'it does not add the --add-opens on Java 8' do
+      it 'does not add the --add-opens on Java 8' do
         component.release
-  
+
         expect(java_opts).not_to include('--add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED')
       end
 
@@ -90,16 +90,16 @@
         delegate         = JavaBuildpack::Component::MutableJavaHome.new
         delegate.root    = app_dir + '.test-java-home'
         delegate.version = JavaBuildpack::Util::TokenizedVersion.new('9.0.1')
-    
+
         delegate
       end
 
       it 'adds the --add-opens on Java 11' do
         component.release
-  
+
         expect(java_opts).to include('--add-opens jdk.management/com.sun.management.internal=ALL-UNNAMED')
       end
-  
+
     end
 
   end
@@ -178,9 +178,9 @@
       expect(java_opts).to include('-javaagent:$PWD/.java-buildpack/java_memory_assistant_agent/' \
         'java-memory-assistant-0.1.0.jar')
 
-        expect(java_opts).to include('\'-Djma.thresholds.heap=>600MB\'')
-        expect(java_opts).to include('\'-Djma.thresholds.eden=< 30MB\'')
-      end
+      expect(java_opts).to include('\'-Djma.thresholds.heap=>600MB\'')
+      expect(java_opts).to include('\'-Djma.thresholds.eden=< 30MB\'')
+    end
 
   end
 
@@ -263,7 +263,7 @@
     end
 
     it 'falls back on JBP log_level when no log_level specified via configuration',
-        :enable_log_file, log_level: 'WARN' do
+       :enable_log_file, log_level: 'WARN' do
       component.release
 
       expect(java_opts).to include('-Djma.log_level=WARNING')