Skip to content

Commit a039e74

Browse files
authored
Merge pull request #837 from jvshahid/fix-appdynamics-appname-escaping
Support appdynamics application names with spaces
2 parents 895590c + 6c0b4ae commit a039e74

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/java_buildpack/framework/app_dynamics_agent.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -80,7 +80,7 @@ def supports?
8080
def application_name(java_opts, credentials)
8181
name = credentials['application-name'] || @configuration['default_application_name'] ||
8282
@application.details['application_name']
83-
java_opts.add_system_property('appdynamics.agent.applicationName', name.to_s)
83+
java_opts.add_system_property('appdynamics.agent.applicationName', "\\\"#{name}\\\"")
8484
end
8585

8686
def account_access_key(java_opts, credentials)

spec/java_buildpack/framework/app_dynamics_agent_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@
6666

6767
expect(java_opts).to include('-javaagent:$PWD/.java-buildpack/app_dynamics_agent/javaagent.jar')
6868
expect(java_opts).to include('-Dappdynamics.controller.hostName=test-host-name')
69-
expect(java_opts).to include('-Dappdynamics.agent.applicationName=test-application-name')
69+
expect(java_opts).to include('-Dappdynamics.agent.applicationName=\"test-application-name\"')
7070
expect(java_opts).to include('-Dappdynamics.agent.tierName=test-application-name')
7171
expect(java_opts).to include('-Dappdynamics.agent.nodeName=$(expr "$VCAP_APPLICATION" : ' \
7272
'\'.*instance_index[": ]*\\([[:digit:]]*\\).*\')')
@@ -88,7 +88,7 @@
8888
it 'adds application_name from credentials to JAVA_OPTS if specified' do
8989
component.release
9090

91-
expect(java_opts).to include('-Dappdynamics.agent.applicationName=another-test-application-name')
91+
expect(java_opts).to include('-Dappdynamics.agent.applicationName=\"another-test-application-name\"')
9292
end
9393
end
9494

0 commit comments

Comments
 (0)