Quote arguments that could have special chars for BASH

[#789]

Signed-off-by: Ben Hale <[email protected]>

Author: mmanciop

lib/java_buildpack/framework/java_memory_assistant/agent.rb

@@ -51,12 +51,15 @@ def release
         end
 
         add_system_prop_if_config_present 'check_interval', 'jma.check_interval'
-        add_system_prop_if_config_present 'max_frequency', 'jma.max_frequency'
+
+        if @configuration.key?('max_frequency')
+          @droplet.java_opts.add_preformatted_options "'-Djma.max_frequency=#{@configuration['max_frequency']}'"
+        end
 
         return unless @configuration.key?('thresholds')
 
         @configuration['thresholds'].each do |key, value|
-          @droplet.java_opts.add_system_property "jma.thresholds.#{key}", value.to_s
+          @droplet.java_opts.add_preformatted_options "'-Djma.thresholds.#{key}=#{value.to_s}'"
         end
       end
 

spec/java_buildpack/framework/java_memory_assistant/agent_spec.rb

@@ -59,10 +59,10 @@
       expect(java_opts).to include('-Djma.enabled=true')
 
       expect(java_opts).to include('-Djma.check_interval=5s')
-      expect(java_opts).to include('-Djma.max_frequency=1/1m')
+      expect(java_opts).to include('\'-Djma.max_frequency=1/1m\'')
 
-      expect(java_opts).to include('-Djma.thresholds.heap=90')
-      expect(java_opts).to include('-Djma.thresholds.old_gen=90')
+      expect(java_opts).to include('\'-Djma.thresholds.heap=90\'')
+      expect(java_opts).to include('\'-Djma.thresholds.old_gen=90\'')
 
     end
 
@@ -132,15 +132,15 @@
         'java-memory-assistant-0.1.0.jar')
       expect(java_opts).to include('-Djma.enabled=true')
       expect(java_opts).to include('-Djma.check_interval=10m')
-      expect(java_opts).to include('-Djma.max_frequency=4/10h')
+      expect(java_opts).to include('\'-Djma.max_frequency=4/10h\'')
       expect(java_opts).to include('-Djma.log_level=DEBUG')
-      expect(java_opts).to include('-Djma.thresholds.heap=60')
-      expect(java_opts).to include('-Djma.thresholds.code_cache=30')
-      expect(java_opts).to include('-Djma.thresholds.metaspace=5')
-      expect(java_opts).to include('-Djma.thresholds.perm_gen=45.5')
-      expect(java_opts).to include('-Djma.thresholds.eden=90')
-      expect(java_opts).to include('-Djma.thresholds.survivor=95.5')
-      expect(java_opts).to include('-Djma.thresholds.old_gen=30')
+      expect(java_opts).to include('\'-Djma.thresholds.heap=60\'')
+      expect(java_opts).to include('\'-Djma.thresholds.code_cache=30\'')
+      expect(java_opts).to include('\'-Djma.thresholds.metaspace=5\'')
+      expect(java_opts).to include('\'-Djma.thresholds.perm_gen=45.5\'')
+      expect(java_opts).to include('\'-Djma.thresholds.eden=90\'')
+      expect(java_opts).to include('\'-Djma.thresholds.survivor=95.5\'')
+      expect(java_opts).to include('\'-Djma.thresholds.old_gen=30\'')
     end
 
   end
@@ -160,6 +160,30 @@
 
   end
 
+  context do
+    let(:configuration) do
+      {
+        'thresholds' => {
+          'heap' => '>600MB',
+          'eden' => '< 30MB'
+        }
+      }
+    end
+
+    let(:version) { '0.1.0' }
+
+    it 'escapses redirection characters' do
+      component.release
+
+      expect(java_opts).to include('-javaagent:$PWD/.java-buildpack/java_memory_assistant_agent/' \
+        'java-memory-assistant-0.1.0.jar')
+
+        expect(java_opts).to include('\'-Djma.thresholds.heap=>600MB\'')
+        expect(java_opts).to include('\'-Djma.thresholds.eden=< 30MB\'')
+      end
+
+  end
+
   context do
     let(:configuration) do
       {