Polishing

[resolves #753]

Signed-off-by: Ben Hale <[email protected]>

Author: nebhale

lib/java_buildpack/framework/app_dynamics_agent.rb

@@ -24,14 +24,6 @@ module Framework
 
     # Encapsulates the functionality for enabling zero-touch AppDynamics support.
     class AppDynamicsAgent < JavaBuildpack::Component::VersionedDependencyComponent
-      @conf_files = [
-        'logging/log4j2.xml',
-        'logging/log4j.xml',
-        'app-agent-config.xml',
-        'controller-info.xml',
-        'service-endpoint.xml',
-        'transactions.xml'
-      ]
 
       def initialize(context)
         super(context)
@@ -43,7 +35,7 @@ def compile
         download_zip(false, @droplet.sandbox, 'AppDynamics Agent')
 
         # acessor for resources dir through @droplet?
-        resources_dir = Pathname.new(File.expand_path('../../../resources', __dir__)).freeze
+        resources_dir    = Pathname.new(File.expand_path('../../../resources', __dir__)).freeze
         default_conf_dir = resources_dir + @droplet.component_id + 'defaults'
 
         copy_appd_default_configuration(default_conf_dir)
@@ -54,7 +46,7 @@ def compile
       # (see JavaBuildpack::Component::BaseComponent#release)
       def release
         credentials = @application.services.find_service(FILTER, 'host-name')['credentials']
-        java_opts = @droplet.java_opts
+        java_opts   = @droplet.java_opts
         java_opts.add_javaagent(@droplet.sandbox + 'javaagent.jar')
 
         application_name java_opts, credentials
@@ -77,9 +69,12 @@ def supports?
 
       private
 
+      CONFIG_FILES = %w[logging/log4j2.xml logging/log4j.xml app-agent-config.xml controller-info.xml
+                        service-endpoint.xml transactions.xml].freeze
+
       FILTER = /app[-]?dynamics/.freeze
 
-      private_constant :FILTER
+      private_constant :CONFIG_FILES, :FILTER
 
       def application_name(java_opts, credentials)
         name = credentials['application-name'] || @configuration['default_application_name'] ||
@@ -177,7 +172,7 @@ def override_default_config_if_applicable
 
         agent_root = @application.environment['APPD_CONF_HTTP_URL'].chomp('/') + '/java/'
         @logger.info { "Downloading override configuration files from #{agent_root}" }
-        JavaBuildpack::Framework::AppDynamicsAgent.instance_variable_get(:@conf_files).each do |conf_file|
+        CONFIG_FILES.each do |conf_file|
           uri = URI(agent_root + conf_file)
 
           # `download()` uses retries with exponential backoff which is expensive

spec/java_buildpack/framework/app_dynamics_agent_spec.rb

@@ -149,7 +149,11 @@
 
         it 'sets APPD_CONF_HTTP_URL env var to download config files from',
            cache_fixture: 'stub-app-dynamics-agent.zip' do
-          conf_files.each do |file|
+
+          config_files = %w[logging/log4j2.xml logging/log4j.xml app-agent-config.xml controller-info.xml
+                            service-endpoint.xml transactions.xml]
+
+          config_files.each do |file|
             uri = "http://foo.com/java/#{file}"
             allow(application_cache).to receive(:get)
               .with(uri)