Fixes rubocop violations (#941)

- Disable empty blocks under spec tests
- Disable string concat style check
- Change lint name to MissingSuper
- Change `ENV[..]` usage to `ENV.fetch(..., nil)`
- Set max for RSpec/MultipleMemoizedHelpers to 10, some tests have a lot of `let(..)` blocks
- Set RSpec/VerifiedDoubleReference to enforce string style
- Consistently use Naming/VariableNumber, some outliers were snake_case and switched to normalcase
- Disable Lint/UselessMethodDefinition in a few specs where it's necessary
- Remove some unnecessary whitespace, char groups and escaping in regex blocks
- Use `be_nil` instead of `be nil`
- Disable Style/GlobalStdStream checks for spec helper
- Reduce complexity of versions_tasks and validate
- Disable helper limit MultipleMemoizedHelpers for droplet helper
- Make the order explicit in a few places by adding parends
- Switch from ifelse to case
- Use File.write
- Remove empty blocks
- Fixes all string alignment issues
- Fixes all string too long issues
- Ignore Ruby 2.6 lints about array slicing since we still need to support Ruby 2.5
- Use an explicit kwargs to be compatible with deprecations and removal in Ruby 2.7 and 3.0
- Bump RubyMine tests to reflect supported version 2.5, 2.7 and 3.0
- Include missing require in filtering_filename_spec.rb that caused it to fail in RubyMine
- Freeze const made from dynamics
- Adjust kwarg expansion so it's compliant for Ruby 3.0 (this requires some version specific behavior in the spec tests)

Signed-off-by: Daniel Mikusa <[email protected]>

Author: Daniel Mikusa

.idea/runConfigurations/All_Tests__2_5_.xml

@@ -3,6 +3,7 @@ require: rubocop-rspec
 
 AllCops:
   NewCops: enable
+  SuggestExtensions: false
   Exclude:
   - 'build/**/*'
 Layout/EmptyLinesAroundBlockBody:
@@ -17,7 +18,7 @@ Layout/LineLength:
 Layout/MultilineOperationIndentation:
   Enabled: false
 Metrics/AbcSize:
- Max: 25
+  Max: 25
 Metrics/BlockLength:
   Exclude:
   - 'spec/**/*.rb'
@@ -53,5 +54,20 @@ Style/Documentation:
   Enabled: false
 Style/FormatStringToken:
   Enabled: false
-Style/MethodMissingSuper:
+Lint/MissingSuper:
+  Enabled: false
+Style/StringConcatenation:
+  Enabled: false
+Lint/EmptyBlock:
+  Exclude:
+    - 'spec/**/*.rb'
+RSpec/MultipleMemoizedHelpers:
+  Max: 10
+RSpec/VerifiedDoubleReference:
+  EnforcedStyle: string
+Style/OptionalBooleanParameter:
   Enabled: false
+Lint/RedundantCopDisableDirective:
+  Enabled: false # disabled as this can be tough to manage across multiple ruby versions
+Style/RedundantFreeze:
+  Enabled: false # enable when we only support ruby 3.0+

.idea/runConfigurations/All_Tests__2_7_.xml

@@ -3,55 +3,59 @@ GEM
   specs:
     addressable (2.8.0)
       public_suffix (>= 2.0.2, < 5.0)
-    ast (2.4.0)
-    crack (0.4.3)
-      safe_yaml (~> 1.0.0)
-    diff-lcs (1.3)
+    ast (2.4.2)
+    crack (0.4.5)
+      rexml
+    diff-lcs (1.5.0)
     hashdiff (1.0.1)
-    jaro_winkler (1.5.4)
-    parallel (1.19.1)
-    parser (2.7.1.1)
-      ast (~> 2.4.0)
-    public_suffix (4.0.6)
-    rainbow (3.0.0)
-    rake (13.0.1)
+    parallel (1.22.1)
+    parser (3.1.2.0)
+      ast (~> 2.4.1)
+    public_suffix (4.0.7)
+    rainbow (3.1.1)
+    rake (13.0.6)
     redcarpet (3.5.1)
+    regexp_parser (2.3.1)
     rexml (3.2.5)
-    rspec (3.9.0)
-      rspec-core (~> 3.9.0)
-      rspec-expectations (~> 3.9.0)
-      rspec-mocks (~> 3.9.0)
-    rspec-core (3.9.1)
-      rspec-support (~> 3.9.1)
-    rspec-expectations (3.9.1)
+    rspec (3.11.0)
+      rspec-core (~> 3.11.0)
+      rspec-expectations (~> 3.11.0)
+      rspec-mocks (~> 3.11.0)
+    rspec-core (3.11.0)
+      rspec-support (~> 3.11.0)
+    rspec-expectations (3.11.0)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-mocks (3.9.1)
+      rspec-support (~> 3.11.0)
+    rspec-mocks (3.11.1)
       diff-lcs (>= 1.2.0, < 2.0)
-      rspec-support (~> 3.9.0)
-    rspec-support (3.9.2)
-    rubocop (0.82.0)
-      jaro_winkler (~> 1.5.1)
+      rspec-support (~> 3.11.0)
+    rspec-support (3.11.0)
+    rubocop (1.28.2)
       parallel (~> 1.10)
-      parser (>= 2.7.0.1)
+      parser (>= 3.1.0.0)
       rainbow (>= 2.2.2, < 4.0)
+      regexp_parser (>= 1.8, < 3.0)
       rexml
+      rubocop-ast (>= 1.17.0, < 2.0)
       ruby-progressbar (~> 1.7)
-      unicode-display_width (>= 1.4.0, < 2.0)
-    rubocop-rspec (1.38.1)
-      rubocop (>= 0.68.1)
-    ruby-progressbar (1.10.1)
-    rubyzip (2.3.0)
-    safe_yaml (1.0.5)
+      unicode-display_width (>= 1.4.0, < 3.0)
+    rubocop-ast (1.17.0)
+      parser (>= 3.1.1.0)
+    rubocop-rspec (2.10.0)
+      rubocop (~> 1.19)
+    ruby-progressbar (1.11.0)
+    rubyzip (2.3.2)
     tee (1.0.0)
-    terminal-table (1.8.0)
-      unicode-display_width (~> 1.1, >= 1.1.1)
-    unicode-display_width (1.7.0)
-    webmock (3.8.3)
-      addressable (>= 2.3.6)
+    terminal-table (3.0.2)
+      unicode-display_width (>= 1.1.1, < 3)
+    unicode-display_width (2.1.0)
+    webmock (3.14.0)
+      addressable (>= 2.8.0)
       crack (>= 0.3.2)
       hashdiff (>= 0.4.0, < 2.0.0)
-    yard (0.9.24)
+    webrick (1.7.0)
+    yard (0.9.27)
+      webrick (~> 1.7.0)
 
 PLATFORMS
   ruby
@@ -69,4 +73,4 @@ DEPENDENCIES
   yard
 
 BUNDLED WITH
-   2.2.16
+   2.3.12