revert host changes to most components

loewenstein-sap · pbusko · loewenstein-sap · commit ae21a457752a · 2026-01-14T10:34:31.000+01:00
Co-authored-by: Pavel Busko &lt;pavel.busko@sap.com&gt;
diff --git a/jobs/loggr-syslog-agent-windows/monit b/jobs/loggr-syslog-agent-windows/monit
@@ -32,7 +32,6 @@
       "AGENT_CERT_FILE_PATH" => "#{certs_dir}/syslog_agent.crt",
       "AGENT_KEY_FILE_PATH" => "#{certs_dir}/syslog_agent.key",
       "AGENT_CIPHER_SUITES" => p("tls.cipher_suites").split(":").join(","),
-      "AGENT_HOST" => "#{p("host")}",
       "AGENT_PORT" => "#{p("port")}",
 
       "DRAIN_SKIP_CERT_VERIFY" => "#{p("drain_skip_cert_verify")}",
diff --git a/jobs/loggr-syslog-agent-windows/spec b/jobs/loggr-syslog-agent-windows/spec
@@ -35,9 +35,6 @@ properties:
     description: Whether metadata is included in structured data by default
     default: true
 
-  host:
-    description: "Host the agent is serving gRPC via mTLS"
-    default: "127.0.0.1"
   port:
     description: "Port the agent is serving gRPC via mTLS"
     default: 3458
diff --git a/jobs/loggr-syslog-agent/spec b/jobs/loggr-syslog-agent/spec
@@ -32,9 +32,6 @@ properties:
   binding_cache_override_url:
     description: URL to use if required to override the default bosh-dns binding cache address
 
-  host:
-    description: "Host the agent is serving gRPC via mTLS"
-    default: "127.0.0.1"
   port:
     description: "Port the agent is serving gRPC via mTLS"
     default: 3458
diff --git a/jobs/loggr-syslog-agent/templates/bpm.yml.erb b/jobs/loggr-syslog-agent/templates/bpm.yml.erb
@@ -23,7 +23,6 @@
       "AGENT_CERT_FILE_PATH" => "#{certs_dir}/syslog_agent.crt",
       "AGENT_KEY_FILE_PATH" => "#{certs_dir}/syslog_agent.key",
       "AGENT_CIPHER_SUITES" => "#{p("tls.cipher_suites").split(":").join(",")}",
-      "AGENT_HOST" => "#{p("host")}",
       "AGENT_PORT" => "#{p("port")}",
       "DRAIN_SKIP_CERT_VERIFY" => "#{p("drain_skip_cert_verify")}",
       "DEFAULT_DRAIN_METADATA" => "#{p("default_drain_metadata")}",
diff --git a/jobs/loggr-udp-forwarder/spec b/jobs/loggr-udp-forwarder/spec
@@ -33,9 +33,6 @@ properties:
     description: |
       The gRPC port to forward the converted v2 envelopes to.
     default: 3458
-  host:
-    description: "Host the agent uses to listen for incoming v1 (dropsonde) envelopes via UDP"
-    default: "127.0.0.1"
   udp_port:
     description: |
       The port to listen for incoming v1 (dropsonde) envelopes via UDP.
diff --git a/jobs/loggr-udp-forwarder/templates/bpm.yml.erb b/jobs/loggr-udp-forwarder/templates/bpm.yml.erb
@@ -13,7 +13,6 @@
         "LOGGREGATOR_AGENT_CERT_FILE_PATH" => "#{certs_dir}/loggregator_agent.crt",
         "LOGGREGATOR_AGENT_KEY_FILE_PATH" => "#{certs_dir}/loggregator_agent.key",
         "LOGGREGATOR_AGENT_ADDR" => "localhost:#{p('loggregator.ingress_port')}",
-        "AGENT_HOST" => "#{p('host')}",
         "UDP_PORT" => "#{p('udp_port')}",
         "DEPLOYMENT" => "#{deployment}",
         "JOB" => "#{job_name}",
diff --git a/jobs/loggregator_agent/spec b/jobs/loggregator_agent/spec
@@ -44,9 +44,6 @@ properties:
   grpc_port:
     description: "Port the agent is listening on to receive gRPC log envelopes"
     default: 3458
-  host:
-    description: "Host the agent is listening on to receive gRPC log envelopes"
-    default: "127.0.0.1"
   zone:
     description: "Availability zone where this agent is running"
     default: ""
diff --git a/jobs/loggregator_agent/templates/bpm.yml.erb b/jobs/loggregator_agent/templates/bpm.yml.erb
@@ -44,7 +44,6 @@ has_doppler = false
       "name" => "loggregator_agent",
       "executable" => "/var/vcap/packages/loggregator_agent/loggregator-agent",
       "env" => {
-        "AGENT_HOST" => "#{p("host")}",
         "AGENT_PORT" => "#{p("grpc_port")}",
         "AGENT_CA_FILE" => "#{certs_dir}/loggregator_ca.crt",
         "AGENT_CERT_FILE" => "#{certs_dir}/loggregator_agent.crt",
diff --git a/jobs/loggregator_agent_windows/monit b/jobs/loggregator_agent_windows/monit
@@ -44,7 +44,6 @@ end
              "__PIPE_SYSLOG_HOST" => p('syslog_daemon_config.address'),
              "__PIPE_SYSLOG_PORT" => p('syslog_daemon_config.port'),
              "__PIPE_SYSLOG_TRANSPORT" => p('syslog_daemon_config.transport'),
-             "AGENT_HOST" => "#{p("host")}",
              "AGENT_PORT" => "#{p("grpc_port")}",
              "AGENT_CA_FILE" => "#{certs_dir}/loggregator_ca.crt",
              "AGENT_CERT_FILE" => "#{certs_dir}/loggregator_agent.crt",
diff --git a/jobs/loggregator_agent_windows/spec b/jobs/loggregator_agent_windows/spec
@@ -66,9 +66,6 @@ properties:
   grpc_port:
     description: "Port the agent is listening on to receive gRPC log envelopes"
     default: 3458
-  host:
-    description: "Host the agent is listening on to receive gRPC log envelopes"
-    default: "127.0.0.1"
   zone:
     description: "Availability zone where this agent is running"
     default: ""
diff --git a/src/cmd/loggregator-agent/app/app_v2.go b/src/cmd/loggregator-agent/app/app_v2.go
@@ -130,7 +130,7 @@ func (a *AppV2) Start() {
 	)
 	go tx.Start()
 
-	agentAddress := fmt.Sprintf("%s:%d", a.config.GRPC.Host, a.config.GRPC.Port)
+	agentAddress := fmt.Sprintf("127.0.0.1:%d", a.config.GRPC.Port)
 	log.Printf("agent v2 API started on addr %s", agentAddress)
 
 	var es envelopeSetter
diff --git a/src/cmd/loggregator-agent/app/config.go b/src/cmd/loggregator-agent/app/config.go
@@ -13,7 +13,6 @@ import (
 // GRPC stores the configuration for the router as a server using a PORT
 // with mTLS certs and as a client.
 type GRPC struct {
-	Host         string   `env:"AGENT_HOST"`
 	Port         uint16   `env:"AGENT_PORT"`
 	CAFile       string   `env:"AGENT_CA_FILE"`
 	CertFile     string   `env:"AGENT_CERT_FILE"`
@@ -51,7 +50,6 @@ func LoadConfig() (*Config, error) {
 			Port: 14824,
 		},
 		GRPC: GRPC{
-			Host: "127.0.0.1",
 			Port: 3458,
 		},
 	}
diff --git a/src/cmd/syslog-agent/app/config.go b/src/cmd/syslog-agent/app/config.go
@@ -14,7 +14,6 @@ import (
 // GRPC stores the configuration for the router as a server using a PORT
 // with mTLS certs and as a client.
 type GRPC struct {
-	Host         string   `env:"AGENT_HOST,                     report"`
 	Port         int      `env:"AGENT_PORT,                     report"`
 	CAFile       string   `env:"AGENT_CA_FILE_PATH,   required, report"`
 	CertFile     string   `env:"AGENT_CERT_FILE_PATH, required, report"`
@@ -64,7 +63,6 @@ func LoadConfig() Config {
 		},
 		GRPC: GRPC{
 			Port: 3458,
-			Host: "127.0.0.1",
 		},
 		AggregateConnectionRefreshInterval: 1 * time.Minute,
 		DefaultDrainMetadata:               true,
diff --git a/src/cmd/syslog-agent/app/syslog_agent.go b/src/cmd/syslog-agent/app/syslog_agent.go
@@ -263,7 +263,7 @@ func (s *SyslogAgent) Run() {
 
 	rx := v2.NewReceiver(diode, im, omm)
 	s.v2Srv = v2.NewServer(
-		fmt.Sprintf("%s:%d", s.grpc.Host, s.grpc.Port),
+		fmt.Sprintf("127.0.0.1:%d", s.grpc.Port),
 		rx,
 		grpc.Creds(serverCreds),
 		grpc.MaxRecvMsgSize(10*1024*1024),
diff --git a/src/cmd/udp-forwarder/app/config.go b/src/cmd/udp-forwarder/app/config.go
@@ -19,9 +19,8 @@ type GRPC struct {
 
 // Config holds the configuration for the UDP agent
 type Config struct {
-	UseRFC3339           bool   `env:"USE_RFC3339"`
-	Host                 string `env:"AGENT_HOST, report"`
-	UDPPort              int    `env:"UDP_PORT, report"`
+	UseRFC3339           bool `env:"USE_RFC3339"`
+	UDPPort              int  `env:"UDP_PORT, report"`
 	LoggregatorAgentGRPC GRPC
 	Deployment           string `env:"DEPLOYMENT, report"`
 	Job                  string `env:"JOB, report"`
@@ -34,7 +33,6 @@ type Config struct {
 // LoadConfig reads from the environment to create a Config.
 func LoadConfig(log *log.Logger) Config {
 	cfg := Config{
-		Host:    "127.0.0.1",
 		UDPPort: 3457,
 		LoggregatorAgentGRPC: GRPC{
 			Addr: "127.0.0.1:3458",
diff --git a/src/cmd/udp-forwarder/app/udp_forwarder.go b/src/cmd/udp-forwarder/app/udp_forwarder.go
@@ -25,7 +25,6 @@ type Metrics interface {
 
 type UDPForwarder struct {
 	grpc         GRPC
-	host         string
 	udpPort      int
 	pprofServer  *http.Server
 	pprofPort    uint16
@@ -45,7 +44,6 @@ type UDPForwarder struct {
 func NewUDPForwarder(cfg Config, l *log.Logger, m Metrics) *UDPForwarder {
 	return &UDPForwarder{
 		grpc:         cfg.LoggregatorAgentGRPC,
-		host:         cfg.Host,
 		udpPort:      cfg.UDPPort,
 		pprofPort:    cfg.MetricsServer.PprofPort,
 		debugMetrics: cfg.MetricsServer.DebugMetrics,
@@ -99,13 +97,13 @@ func (u *UDPForwarder) Run() {
 	dropsondeUnmarshaller := ingress.NewUnMarshaller(w)
 	u.mu.Lock()
 	u.nr, err = ingress.NewNetworkReader(
-		fmt.Sprintf("%s:%d", u.host, u.udpPort),
+		fmt.Sprintf("127.0.0.1:%d", u.udpPort),
 		dropsondeUnmarshaller,
 		u.metrics,
 	)
 	u.mu.Unlock()
 	if err != nil {
-		u.log.Fatalf("Failed to listen on %s:%d: %s", u.host, u.udpPort, err)
+		u.log.Fatalf("Failed to listen on 127.0.0.1:%d: %s", u.udpPort, err)
 	}
 
 	go u.nr.StartReading()
