fix linter findings

Author: chombium

src/integration_tests/trafficcontroller/fake_uaa_server_test.go

@@ -20,7 +20,7 @@ func (h *FakeUaaHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	token := r.FormValue("token")
+	token := r.FormValue("token") //nolint:gosec
 
 	switch token {
 	case "iAmAnAdmin":

src/rlp/app/rlp.go

@@ -53,7 +53,7 @@ type RLP struct {
 
 // NewRLP returns a new unstarted RLP.
 func NewRLP(m MetricClient, opts ...RLPOption) *RLP {
-	ctx, cancel := context.WithCancel(context.Background())
+	ctx, cancel := context.WithCancel(context.Background()) //nolint:gosec
 	rlp := &RLP{
 		ingressAddrs:         []string{"doppler.service.cf.internal"},
 		ingressDialOpts:      []grpc.DialOption{grpc.WithTransportCredentials(insecure.NewCredentials())},

src/trafficcontroller/internal/auth/uaa_client_test.go

@@ -147,7 +147,7 @@ func (h *FakeUaaHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 		return
 	}
 
-	token := r.FormValue("token")
+	token := r.FormValue("token") //nolint:gosec
 
 	switch token {
 	case "iAmAnAdmin":

src/trafficcontroller/internal/proxy/doppler_proxy_test.go

@@ -104,7 +104,7 @@ var _ = Describe("DopplerProxy", func() {
 		})
 
 		It("returns a bad request if the form does not parse", func() {
-			req, _ := http.NewRequest("POST", "/set-cookie", nil)
+			req, _ := http.NewRequest("POST", "/set-cookie", http.NoBody)
 			req.Header.Set("Content-Type", "application/x-www-form-urlencoded")
 
 			dopplerProxy.ServeHTTP(recorder, req)

src/trafficcontroller/internal/proxy/set_cookie_handler.go

@@ -13,7 +13,11 @@ func NewSetCookieHandler(domain string) *SetCookieHandler {
 }
 
 func (h SetCookieHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
-	if err := r.ParseForm(); err != nil {
+	if r.Body != nil {
+		r.Body = http.MaxBytesReader(w, r.Body, 4096) // limit request body to 4kB
+	}
+	err := r.ParseForm()
+	if err != nil || r.FormValue("CookieName") == "" || r.FormValue("CookieValue") == "" {
 		w.WriteHeader(http.StatusBadRequest)
 		return
 	}