Skip to content

Tests are skipped on Mac OS #108

@thepeterstone

Description

@thepeterstone

Is this an Issue/Bug or a Feature Request?

[x] Issue or Bug
[ ] Feature Request

What is this issue about? Or why do you want this feature?

There multiple places in the test suite where we make a runtime check and skip the test on Mac OS. This works around some flaky test behavior but lowers the utility of the suite and leads to build breaks due to false negatives.

  1. src/internal/acceptance/metric-store/metric_store_test.go#L521
  2. src/internal/acceptance/metric-store/metric_store_test.go#L538
  3. src/internal/acceptance/metric-store/metric_store_test.go#L560
  4. src/performance/performance_test.go#L30
  5. src/pkg/leanstreams/leanstreams_test.go#L229
  6. src/pkg/leanstreams/leanstreams_test.go#L254
  7. src/pkg/ingressclient/ingressclient_test.go#L61
What version of Metric Store are you using?

develop

Please provide output that helps describe the issue:

For example, the ingressclient:

IngressClient
  errors if writing fails
  /Users/pstone/workspace/metric-store-release/src/pkg/ingressclient/ingressclient_test.go:59

S [SKIPPING] [0.004 seconds]
IngressClient
/Users/pstone/workspace/metric-store-release/src/pkg/ingressclient/ingressclient_test.go:18
  errors if writing fails [It]
  /Users/pstone/workspace/metric-store-release/src/pkg/ingressclient/ingressclient_test.go:59

  doesn't work on Mac OS

  /Users/pstone/workspace/metric-store-release/src/pkg/ingressclient/ingressclient_test.go:61
Is there anything unique or special about your setup?

Running scripts/test on a Mac.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    Status

    Inbox

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions