Fixing env from ApplicationConfiguration

LMCROSSITXSADEPLOY-3413

Author: karrgov

multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/Messages.java

@@ -149,6 +149,7 @@ public final class Messages {
     public static final String GLOBAL_CONFIG_SPACE = "Global config space: {0}";
     public static final String OBJECT_STORE_CLIENT_TYPE = "Object store client type: {0}";
     public static final String APPLICATION_GUID = "Application GUID: {0}";
+    public static final String USE_LEGACY_ROUTE_WARNING = "Legacy route warning enablement: {0}";
     public static final String APPLICATION_INSTANCE_INDEX = "Application instance index: {0}";
     public static final String AUDIT_LOG_CLIENT_CORE_THREADS = "Audit log client core threads: {0}";
     public static final String AUDIT_LOG_CLIENT_MAX_THREADS = "Audit log client max threads: {0}";

multiapps-controller-core/src/main/java/org/cloudfoundry/multiapps/controller/core/util/ApplicationConfiguration.java

@@ -9,6 +9,7 @@
 import java.util.Set;
 import java.util.concurrent.TimeUnit;
 import java.util.stream.Collectors;
+
 import jakarta.inject.Inject;
 import jakarta.inject.Named;
 import org.apache.commons.collections4.CollectionUtils;
@@ -26,6 +27,7 @@
 import org.slf4j.LoggerFactory;
 import org.springframework.context.annotation.Lazy;
 import org.springframework.scheduling.support.CronExpression;
+
 import static java.text.MessageFormat.format;
 
 @Named
@@ -99,6 +101,7 @@ public class ApplicationConfiguration {
     static final String CFG_THREADS_FOR_FILE_UPLOAD_TO_CONTROLLER = "THREADS_FOR_FILE_UPLOAD_TO_CONTROLLER";
     static final String CFG_THREADS_FOR_FILE_STORAGE_UPLOAD = "THREADS_FOR_FILE_STORAGE_UPLOAD";
     static final String CFG_IS_HEALTH_CHECK_ENABLED = "IS_HEALTH_CHECK_ENABLED";
+    static final String USE_LEGACY_ROUTE_WARNING = "USE_LEGACY_ROUTE_WARNING";
 
     private static final List<String> VCAP_APPLICATION_URIS_KEYS = List.of("full_application_uris", "application_uris", "uris");
 
@@ -158,6 +161,7 @@ public class ApplicationConfiguration {
     public static final int DEFAULT_THREADS_FOR_FILE_STORAGE_UPLOAD = 7;
     public static final boolean DEFAULT_IS_HEALTH_CHECK_ENABLED = false;
     public static final Boolean DEFAULT_IS_READINESS_HEALTH_CHECK_ENABLED = Boolean.FALSE;
+    public static final Boolean DEFAULT_USE_LEGACY_ROUTE_WARNING = false;
 
     protected final Environment environment;
 
@@ -218,6 +222,7 @@ public class ApplicationConfiguration {
     private Boolean isHealthCheckEnabled;
     private Set<String> objectStoreRegions;
     private Boolean isReadinessHealthCheckEnabled;
+    private Boolean useLegacyRouteWarning;
 
     public ApplicationConfiguration() {
         this(new Environment());
@@ -500,6 +505,13 @@ public String getObjectStoreClientType() {
         return objectStoreClientType;
     }
 
+    public Boolean getLegacyRouteWarningEnablement() {
+        if (useLegacyRouteWarning == null) {
+            useLegacyRouteWarning = getLegacyRouteWarningEnablementFromEnvironment();
+        }
+        return useLegacyRouteWarning;
+    }
+
     public HealthCheckConfiguration getHealthCheckConfiguration() {
         if (healthCheckConfiguration == null) {
             healthCheckConfiguration = getHealthCheckConfigurationFromEnvironment();
@@ -916,6 +928,12 @@ private String getObjectStoreClientTypeFromEnvironment() {
         return value;
     }
 
+    private Boolean getLegacyRouteWarningEnablementFromEnvironment() {
+        Boolean value = environment.getBoolean(USE_LEGACY_ROUTE_WARNING, DEFAULT_USE_LEGACY_ROUTE_WARNING);
+        logEnvironmentVariable(USE_LEGACY_ROUTE_WARNING, Messages.USE_LEGACY_ROUTE_WARNING, value);
+        return value;
+    }
+
     private HealthCheckConfiguration getHealthCheckConfigurationFromEnvironment() {
         HealthCheckConfiguration healthCheckConfigurationFromEnvironment = ImmutableHealthCheckConfiguration.builder()
                                                                                                             .spaceId(