Skip to content

Commit e1ba8f6

Browse files
authored
Fix failing tests (go bp cflinuxfs4 and pip vendor) (#684)
* Revert changes until go bp (cflinuxfs4) is available on cf environments * Update integration tests to reflect changes to vendored deps (#638)
1 parent bd1438b commit e1ba8f6

File tree

2 files changed

+11
-4
lines changed

2 files changed

+11
-4
lines changed

src/python/integration/deploy_python_app_pipenv_test.go

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,9 +68,11 @@ var _ = Describe("deploying a flask web app", func() {
6868
app.SetEnv("BP_DEBUG", "1")
6969
})
7070

71-
It("should work by downloading the missing dependency", func() {
72-
PushAppAndConfirm(app)
73-
Expect(app.GetBody("/")).To(ContainSubstring("Hello, World with pipenv!"))
71+
It("should fail because it requires all dependencies to be vendored", func() {
72+
Expect(app.Push()).ToNot(Succeed())
73+
Expect(app.Stdout.String()).ToNot(ContainSubstring("-----> Installing python"))
74+
Expect(app.Stdout.String()).ToNot(ContainSubstring("Running Pip Install (Vendored)"))
75+
Expect(app.Stdout.String()).ToNot(ContainSubstring("Running pip install failed. You need to include all dependencies in the vendor directory."))
7476
})
7577
})
7678
})

src/python/integration/deploy_python_app_with_dynatrace_test.go

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,7 @@ package integration_test
22

33
import (
44
"fmt"
5+
"os"
56
"os/exec"
67
"path/filepath"
78
"time"
@@ -26,7 +27,11 @@ var _ = Describe("CF Python Buildpack", func() {
2627
}
2728

2829
dynatraceAPI = cutlass.New(Fixtures("fake_dynatrace_api"))
29-
30+
// TODO: remove this once go-buildpack runs on cflinuxfs4
31+
// This is done to have the dynatrace broker app written in go up and running
32+
if os.Getenv("CF_STACK") == "cflinuxfs4" {
33+
dynatraceAPI.Stack = "cflinuxfs3"
34+
}
3035
dynatraceAPI.SetEnv("BP_DEBUG", "true")
3136

3237
Expect(dynatraceAPI.Push()).To(Succeed())

0 commit comments

Comments
 (0)