fix: properties print empty json when object not exist

Author: serdarozerr

gcs/client/client.go

@@ -137,7 +137,6 @@ func (client *GCSBlobstore) getReader(gcs *storage.Client, src string) (*storage
 const retryAttempts = 3
 
 func (client *GCSBlobstore) Put(sourceFilePath string, dest string) error {
-
 	src, err := os.Open(sourceFilePath)
 	if err != nil {
 		return err
@@ -319,6 +318,10 @@ func (client *GCSBlobstore) Properties(dest string) error {
 	attr, err := oh.Attrs(context.Background())
 
 	if err != nil {
+		if errors.Is(err, storage.ErrObjectNotExist) {
+			fmt.Println(`{}`)
+			return nil
+		}
 		return fmt.Errorf("getting attributes: %w", err)
 	}
 

gcs/integration/assertions.go

@@ -47,14 +47,6 @@ func AssertLifecycleWorks(gcsCLIPath string, ctx AssertContext) {
 	Expect(session.ExitCode()).To(BeZero())
 	Expect(session.Err.Contents()).To(MatchRegexp("File '.*' exists in bucket '.*'"))
 
-	session, err = RunGCSCLI(gcsCLIPath, ctx.ConfigPath, storageType, "properties", ctx.GCSFileName)
-	Expect(err).ToNot(HaveOccurred())
-	Expect(session.ExitCode()).To(BeZero())
-	output := string(session.Out.Contents())
-	Expect(output).To(MatchRegexp(`"etag":\s*".+?"`))
-	Expect(output).To(MatchRegexp(`"last_modified":\s*".+?"`))
-	Expect(output).To(MatchRegexp(`"content_length":\s*\d+`))
-
 	tmpLocalFileName := "gcscli-download"
 	defer os.Remove(tmpLocalFileName) //nolint:errcheck
 
@@ -206,3 +198,28 @@ func AssertListMultipleWithPrefixLifecycle(gcsCLIPath string, ctx AssertContext)
 	Expect(err).ToNot(HaveOccurred())
 	Expect(session.ExitCode()).To(BeZero())
 }
+
+func AssertPropertiesLifecycle(gcsCLIPath string, ctx AssertContext) {
+	storageType := "gcs"
+	session, err := RunGCSCLI(gcsCLIPath, ctx.ConfigPath, storageType, "put", ctx.ContentFile, ctx.GCSFileName)
+	Expect(err).ToNot(HaveOccurred())
+	Expect(session.ExitCode()).To(BeZero())
+
+	session, err = RunGCSCLI(gcsCLIPath, ctx.ConfigPath, storageType, "properties", ctx.GCSFileName)
+	Expect(err).ToNot(HaveOccurred())
+	Expect(session.ExitCode()).To(BeZero())
+	output := string(session.Out.Contents())
+	Expect(output).To(MatchRegexp(`"etag":\s*".+?"`))
+	Expect(output).To(MatchRegexp(`"last_modified":\s*".+?"`))
+	Expect(output).To(MatchRegexp(`"content_length":\s*\d+`))
+
+	session, err = RunGCSCLI(gcsCLIPath, ctx.ConfigPath, storageType, "delete", ctx.GCSFileName)
+	Expect(err).ToNot(HaveOccurred())
+	Expect(session.ExitCode()).To(BeZero())
+
+	session, err = RunGCSCLI(gcsCLIPath, ctx.ConfigPath, storageType, "properties", ctx.GCSFileName)
+	Expect(err).ToNot(HaveOccurred())
+	Expect(session.ExitCode()).To(BeZero())
+	Expect(string(session.Out.Contents())).To(MatchRegexp("{}"))
+
+}

gcs/integration/gcs_general_test.go

@@ -142,6 +142,11 @@ var _ = Describe("Integration", func() {
 
 		}, configurations)
 
+		DescribeTable("properties should print json", func(config *config.GCSCli) {
+			env.AddConfig(config)
+			AssertPropertiesLifecycle(gcsCLIPath, env)
+		}, configurations)
+
 		Context("when bucket is not exist", func() {
 			DescribeTable("ensure storage exist will create a new bucket", func(cfg *config.GCSCli) {
 				// create new a newCfg instead of modifying shared cfg accross all tests