fix : service instance update with new service plan (#248)

Author: Bhuvisha03

internal/provider/resource_service_instance.go

@@ -451,23 +451,8 @@ func (r *serviceInstanceResource) Update(ctx context.Context, req resource.Updat
 		if plan.Name.ValueString() != previousState.Name.ValueString() {
 			updateServiceInstance.Name = plan.Name.ValueStringPointer()
 		}
-		// Check if the service plan is different from the previous state
+		//Check if service plan is different from the previous state
 		if plan.ServicePlan.ValueString() != previousState.ServicePlan.ValueString() {
-			ok, err := isServiceInstanceUpgradable(ctx, previousState.ID.ValueString(), *r.cfClient)
-			if err != nil {
-				resp.Diagnostics.AddError(
-					"Error in checking service instance upgradability",
-					"Unable to check service instance upgradability"+plan.Name.ValueString()+": "+err.Error(),
-				)
-				return
-			}
-			if !ok {
-				resp.Diagnostics.AddError(
-					"Service instance not upgradable",
-					"Service instance "+plan.Name.ValueString()+" is not upgradable",
-				)
-				return
-			}
 			updateServiceInstance.Relationships = &cfv3resource.ServiceInstanceRelationships{
 				ServicePlan: &cfv3resource.ToOneRelationship{
 					Data: &cfv3resource.Relationship{

internal/provider/types_service_instance.go

@@ -2,15 +2,13 @@ package provider
 
 import (
 	"context"
-	"time"
-
-	cfv3client "github.com/cloudfoundry/go-cfclient/v3/client"
 	"github.com/cloudfoundry/go-cfclient/v3/resource"
 	"github.com/hashicorp/terraform-plugin-framework-jsontypes/jsontypes"
 	"github.com/hashicorp/terraform-plugin-framework-timeouts/resource/timeouts"
 	"github.com/hashicorp/terraform-plugin-framework/attr"
 	"github.com/hashicorp/terraform-plugin-framework/diag"
 	"github.com/hashicorp/terraform-plugin-framework/types"
+	"time"
 )
 
 type serviceInstanceType struct {
@@ -275,16 +273,6 @@ func mapMaintenanceInfo(value resource.ServiceInstanceMaintenanceInfo) maintenan
 
 }
 
-// isServiceInstanceUpgradable checks if the service instance is upgradable
-// some service instances may not be upgradable.
-func isServiceInstanceUpgradable(ctx context.Context, guid string, c cfv3client.Client) (bool, error) {
-	svc, err := c.ServiceInstances.Get(ctx, guid)
-	if err != nil {
-		return false, err
-	}
-	return svc.UpgradeAvailable != nil && *svc.UpgradeAvailable, nil
-}
-
 // toTagsList converts aliases of type types.Set into a slice of strings.
 func toTagsList(ctx context.Context, tagsSet types.List) ([]string, diag.Diagnostics) {