fix: List datasources throws error when list is empty (#103)

* update domains datasource

* updating spaces data source

* updating org quotas

* updating org roles

* updating space roles

* updating space quotas

* updating stacks datasource

* updating list data sources

* Rerecorded data sources tests

* rerecorded space quotas fixture

* Rerecorded service_route_bindings

---------

Signed-off-by: Ray <debaditya.ray@sap.com>
Co-authored-by: Debaditya <debadityaray00@gmail.com>

Author: ANUGRAHG

internal/provider/datasource_apps.go

@@ -269,14 +269,6 @@ func (d *appsDataSource) Read(ctx context.Context, req datasource.ReadRequest, r
 		return
 	}
 
-	if len(apps) == 0 {
-		resp.Diagnostics.AddError(
-			"Unable to find any app in list",
-			"No app present with mentioned criteria",
-		)
-		return
-	}
-
 	appsList := []DatasourceAppType{}
 	for _, app := range apps {
 

internal/provider/datasource_apps_test.go

@@ -1,7 +1,6 @@
 package provider
 
 import (
-	"regexp"
 	"testing"
 
 	"github.com/hashicorp/terraform-plugin-testing/helper/resource"
@@ -24,7 +23,7 @@ func TestAppsDataSource_Configure(t *testing.T) {
 						space = "02c0cc92-6ecc-44b1-b7b2-096ca19ee143"
 					}`,
 					Check: resource.ComposeTestCheckFunc(
-						resource.TestCheckResourceAttr(resourceName, "apps.#", "8"),
+						resource.TestCheckResourceAttr(resourceName, "apps.#", "9"),
 					),
 				},
 				{
@@ -42,6 +41,7 @@ func TestAppsDataSource_Configure(t *testing.T) {
 	})
 	t.Run("error path - get unavailable apps", func(t *testing.T) {
 		cfg := getCFHomeConf()
+		resourceName := "data.cloudfoundry_apps.apps"
 		rec := cfg.SetupVCR(t, "fixtures/datasource_apps_invalid")
 		defer stopQuietly(rec)
 		resource.Test(t, resource.TestCase{
@@ -54,7 +54,9 @@ func TestAppsDataSource_Configure(t *testing.T) {
 							space = "02c0cc92-6ecc-44b1-b7b2-096ca19ee143"
 							name = "blah"
 						}`,
-					ExpectError: regexp.MustCompile(`Unable to find any app in list`),
+					Check: resource.ComposeTestCheckFunc(
+						resource.TestCheckResourceAttr(resourceName, "apps.#", "0"),
+					),
 				},
 			},
 		})

internal/provider/datasource_buildpacks.go

@@ -138,14 +138,6 @@ func (d *buildpacksDataSource) Read(ctx context.Context, req datasource.ReadRequ
 		return
 	}
 
-	if len(buildpacks) == 0 {
-		resp.Diagnostics.AddError(
-			"Unable to find any buildpack in the list",
-			"No buildpack present with mentioned criteria",
-		)
-		return
-	}
-
 	data.Buildpacks, diags = mapBuildpacksValuesToType(ctx, buildpacks)
 	resp.Diagnostics.Append(diags...)
 

internal/provider/datasource_buildpacks_test.go

@@ -2,7 +2,6 @@ package provider
 
 import (
 	"bytes"
-	"regexp"
 	"testing"
 	"text/template"
 
@@ -64,7 +63,9 @@ func TestBuildpacksDataSource_Configure(t *testing.T) {
 						HclObjectName: "ds",
 						Name:          &invalidOrgGUID,
 					}),
-					ExpectError: regexp.MustCompile(`Unable to find any buildpack in the list`),
+					Check: resource.ComposeAggregateTestCheckFunc(
+						resource.TestCheckResourceAttr(resourceName, "buildpacks.#", "0"),
+					),
 				},
 			},
 		})

internal/provider/datasource_domains.go

@@ -146,14 +146,6 @@ func (d *DomainsDataSource) Read(ctx context.Context, req datasource.ReadRequest
 		return
 	}
 
-	if len(domains) == 0 {
-		resp.Diagnostics.AddError(
-			"Unable to find any domain in the list",
-			"No domain present with mentioned criteria",
-		)
-		return
-	}
-
 	data.Domains, diags = mapDomainsValuesToType(ctx, domains)
 	resp.Diagnostics.Append(diags...)
 

internal/provider/datasource_isolation_segments.go

@@ -102,14 +102,6 @@ func (d *IsolationSegmentsDataSource) Read(ctx context.Context, req datasource.R
 		return
 	}
 
-	if len(isolationSegments) == 0 {
-		resp.Diagnostics.AddError(
-			"Unable to find any Isolation Segment in given list",
-			"No isolation segment found with given criteria",
-		)
-		return
-	}
-
 	data.IsolationSegments, diags = mapIsolationSegmentsValuesToType(ctx, isolationSegments)
 	resp.Diagnostics.Append(diags...)
 

internal/provider/datasource_isolation_segments_test.go

@@ -2,7 +2,6 @@ package provider
 
 import (
 	"bytes"
-	"regexp"
 	"testing"
 	"text/template"
 
@@ -85,7 +84,9 @@ func TestIsolationSegmentsDataSource_Configure(t *testing.T) {
 						HclObjectName: "ds",
 						Name:          strtostrptr("testunavailable"),
 					}),
-					ExpectError: regexp.MustCompile(`Unable to find any Isolation Segment in given list`),
+					Check: resource.ComposeAggregateTestCheckFunc(
+						resource.TestCheckResourceAttr(resourceName, "isolation_segments.#", "0"),
+					),
 				},
 			},
 		})

internal/provider/datasource_org_quotas.go

@@ -161,13 +161,6 @@ func (d *OrgQuotasDataSource) Read(ctx context.Context, req datasource.ReadReque
 		)
 		return
 	}
-	if len(orgQuotas) == 0 {
-		resp.Diagnostics.AddError(
-			"Unable to find any org quota",
-			fmt.Sprintf("No org quota present under org %s with mentioned criteria", data.Org.ValueString()),
-		)
-		return
-	}
 
 	data.OrgQuotas, diags = mapOrgQuotasValuesToType(orgQuotas)
 	resp.Diagnostics.Append(diags...)

internal/provider/datasource_org_roles.go

@@ -154,14 +154,6 @@ func (d *OrgRolesDataSource) Read(ctx context.Context, req datasource.ReadReques
 		return
 	}
 
-	if len(roles) == 0 {
-		resp.Diagnostics.AddError(
-			"Unable to find any roles in list",
-			fmt.Sprintf("No roles present under org %s with mentioned criteria", data.Org.ValueString()),
-		)
-		return
-	}
-
 	data.Roles = mapOrgRolesValuesToType(roles)
 
 	tflog.Trace(ctx, "read a org roles data source")

internal/provider/datasource_org_roles_test.go

@@ -70,7 +70,7 @@ func TestOrgRolesDataSource_Configure(t *testing.T) {
 					}),
 					Check: resource.ComposeAggregateTestCheckFunc(
 						resource.TestCheckResourceAttr(dataSourceName, "org", testOrgGuid),
-						resource.TestCheckResourceAttr(dataSourceName, "roles.#", "2")),
+						resource.TestCheckResourceAttr(dataSourceName, "roles.#", "5")),
 				},
 				{
 					Config: hclProvider(nil) + hclOrgRolesDataSource(&OrgRolesModelPtr{
@@ -81,7 +81,7 @@ func TestOrgRolesDataSource_Configure(t *testing.T) {
 					}),
 					Check: resource.ComposeAggregateTestCheckFunc(
 						resource.TestCheckResourceAttr(dataSourceName, "org", testOrgGuid),
-						resource.TestCheckResourceAttr(dataSourceName, "roles.#", "1")),
+						resource.TestCheckResourceAttr(dataSourceName, "roles.#", "2")),
 				},
 			},
 		})