Skip to content

Feature/import service instance sharing #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 1, 2025
Merged

Feature/import service instance sharing #265

merged 6 commits into from
Sep 1, 2025

Conversation

sderkaczdv
Copy link
Contributor

@sderkaczdv sderkaczdv commented Aug 8, 2025 •
edited by lechnerc77
Loading

Purpose

  • Added import of service instance sharing resource.

  • Adjusted existing tests

  • Added new test for import feature

  • ...

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

How to Test

  • Test the code via automated test
go test ./...
  • Additional test steps
...

What to Check

Verify that the following are valid:

  • Automated tests are executed successfully
  • ...

Other Information

Checklist for reviewer

The following organizational tasks must be completed before merging this PR:

  • The PR is assigned to the Terraform project and a status is set (typically "in review").
  • The PR has the matching labels assigned to it.
  • The PR has a milestone assigned to it.
  • If the PR closes an issue, the issue is referenced.
  • Possible follow-up items are created and linked.

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Aug 8, 2025 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@vipinvkmenon
Copy link
Member

Kindly run the go generate / make generate and add the change commits of the documents generated as well.

@lechnerc77 lechnerc77 added the enhancement New feature or request label Aug 22, 2025
@lechnerc77
Copy link
Contributor

@sderkaczdv Thanks for your contribution. Can you please sign the CLA agreement as this is a prerequisite for us to be able to accept your contribution.
In addition, please add another commit with the updated documentation. You can generate that via make generate.

@lechnerc77 lechnerc77 linked an issue Aug 22, 2025 that may be closed by this pull request
[FEATURE] Add import to service instance sharing resource #228
Closed
@lechnerc77 lechnerc77 added the needs-author-feedback Further information needed from the author of the issue label Aug 26, 2025
@lechnerc77
Copy link
Contributor

@sderkaczdv Thanks for updating the PR. However, we still require the sign off of the CLA agreement, before we can proceed.

@github-actions github-actions bot removed the needs-author-feedback Further information needed from the author of the issue label Aug 27, 2025
@sderkaczdv
Copy link
Contributor Author

@sderkaczdv Thanks for updating the PR. However, we still require the sign off of the CLA agreement, before we can proceed.

The CLA agreement is done

@vipinvkmenon vipinvkmenon merged commit 78edac1 into cloudfoundry:main Sep 1, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vipinvkmenon vipinvkmenon vipinvkmenon approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add import to service instance sharing resource
3 participants
@sderkaczdv @vipinvkmenon @lechnerc77