Sonar

Signed-off-by: Duane May <[email protected]>

Author: duanemay

server/src/main/java/org/cloudfoundry/identity/uaa/provider/ldap/extension/LdapAuthority.java

@@ -24,6 +24,7 @@
  * An authority that contains at least a DN and a role name for an LDAP entry
  * but can also contain other desired attributes to be fetched during an LDAP
  * authority search.
+ *
  * @author Filip Hanik
  */
 public class LdapAuthority implements GrantedAuthority {
@@ -84,16 +85,14 @@ public boolean equals(Object o) {
         if (this == o) {
             return true;
         }
-        if (!(o instanceof LdapAuthority)) {
+        if (!(o instanceof LdapAuthority that)) {
             return false;
         }
 
-        LdapAuthority that = (LdapAuthority) o;
-
         if (!dn.equals(that.dn)) {
             return false;
         }
-        return !!Objects.equals(role, that.role);
+        return Objects.equals(role, that.role);
     }
 
     @Override

server/src/main/java/org/cloudfoundry/identity/uaa/scim/event/GroupModifiedEvent.java

@@ -127,7 +127,7 @@ public boolean equals(Object o) {
             if (!group.equals(groupInfo.group)) {
                 return false;
             }
-            return !!Arrays.equals(members, groupInfo.members);
+            return Arrays.equals(members, groupInfo.members);
         }
 
         @Override

server/src/main/java/org/cloudfoundry/identity/uaa/security/web/UaaRequestMatcher.java

@@ -54,8 +54,6 @@ public UaaRequestMatcher(String path) {
     /**
      * The HttpMethod that the request should be made with. Optional (if null,
      * then all values match)
-     *
-     * @param method
      */
     public void setMethod(HttpMethod method) {
         this.method = method;
@@ -155,10 +153,9 @@ private boolean matchesAcceptHeader(String requestValue, List<String> expectedVa
 
     @Override
     public boolean equals(Object obj) {
-        if (!(obj instanceof UaaRequestMatcher)) {
+        if (!(obj instanceof UaaRequestMatcher other)) {
             return false;
         }
-        UaaRequestMatcher other = (UaaRequestMatcher) obj;
         if (!this.path.equals(other.path)) {
             return false;
         }
@@ -177,8 +174,8 @@ public boolean equals(Object obj) {
             return false;
         }
 
-        return !!((this.expectedHeaders == null && other.expectedHeaders == null) || (this.expectedHeaders != null && this.expectedHeaders
-                .equals(other.expectedHeaders)));
+        return (this.expectedHeaders == null && other.expectedHeaders == null) || (this.expectedHeaders != null && this.expectedHeaders
+                .equals(other.expectedHeaders));
     }
 
     @Override