Skip to content

Commit 0b9d528

Browse files
authored
Give Columns Rhythm (#1848)
This PR updates the default styling for Gutenberg Column blocks to add our standard rhythm styles to the columns, so their contents will be properly spaced. Fixes #1827
1 parent 22b2c7f commit 0b9d528

File tree

3 files changed

+30
-16
lines changed

3 files changed

+30
-16
lines changed

.changeset/early-cups-clean.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@cloudfour/patterns": minor
3+
---
4+
5+
Update Columns block to use our standard rhythm styles so items contained in the columns will have the proper spacing.

src/vendor/wordpress/core-blocks.stories.mdx

Lines changed: 16 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -119,27 +119,27 @@ set to `display: flex`.
119119
<Canvas>
120120
<Story name="Columns">
121121
{`<div class="wp-block-columns">
122-
<div class="wp-block-column" style="flex-basis:37.5%">
122+
<div class="wp-block-column" style="flex-basis: 66.66%">
123+
<h2>Our Designers Code, Our Developers Design</h2>
123124
<p>
124-
Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent et eros
125-
eu felis.
126-
</p>
127-
<figure class="wp-block-image">
128-
<img src="/media/Windbuchencom.jpg" alt="" />
129-
</figure>
130-
<p>Suspendisse commodo neque lacus, a dictum orci interdum et.</p>
131-
</div>
132-
<div class="wp-block-column" style="flex-basis:62.5%">
133-
<p>
134-
Etiam et egestas lorem. Vivamus sagittis sit amet dolor quis lobortis.
135-
Integer sed fermentum arcu, id vulputate lacus. Etiam fermentum sem eu
136-
quam hendrerit.
125+
Our sprint-based process works because we’re full of what our industry
126+
considers unicorns. Our designers write code. Our developers went to art
127+
school.
137128
</p>
138129
<p>
139-
Nam risus massa, ullamcorper consectetur eros fermentum, porta aliquet
140-
ligula. Sed vel mauris nec enim.
130+
We didn’t set out to become a unicorn safe haven, but we’re happy it
131+
happened. <a href="https://cloudfour.com/is">Our team</a>’s unique
132+
combination of skills is what enables us to do great work for our clients.
141133
</p>
142134
</div>
135+
<div class="wp-block-column" style="flex-basis: 33.33%">
136+
<figure class="wp-block-image size-full">
137+
<img
138+
src="https://cloudfour.com/wp-content/uploads/2016/07/approach-unicorn.svg"
139+
alt=""
140+
/>
141+
</figure>
142+
</div>
143143
</div>`}
144144
</Story>
145145
</Canvas>

src/vendor/wordpress/styles/_core-blocks.scss

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -95,6 +95,15 @@ $wp-button-gap: size.$spacing-gap-button-group-default;
9595
}
9696
}
9797

98+
/**
99+
* Gutenberg Block: Columns
100+
*
101+
* 1. Apply our standard rhythm styles to the contents of Columns.
102+
*/
103+
.wp-block-column {
104+
@include spacing.vertical-rhythm; // 1
105+
}
106+
98107
/**
99108
* Gutenberg Block: Group
100109
* Styles for Gutenberg group blocks

0 commit comments

Comments
 (0)