Skip to content

Commit b434c5d

Browse files
authored
Add [email protected] as a devDependency (#1993)
This PR adds `[email protected]` as a devDependency. Previously, this was being implicitly added via the Cloud Four Stylelint config, which specifies `stylelint-scss@^4.0.0` via Stylelint's recommended SCSS config. However, there's a bug in v4.0.0 that was fixed in v4.0.1, and we wanted that fix. Since v4.0.1 was released over 8 months ago and the configs don't seem to be in a rush to bump the version, we're doing it by hand. Someday when the recommended config bumps their version, we could remove this devDependency. Fixes #1890
1 parent 705562e commit b434c5d

File tree

3 files changed

+10
-12
lines changed

3 files changed

+10
-12
lines changed

package-lock.json

Lines changed: 9 additions & 8 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -108,6 +108,7 @@
108108
"stylelint": "14.9.1",
109109
"stylelint-config-cloudfour": "5.1.0",
110110
"stylelint-config-prettier": "9.0.3",
111+
"stylelint-scss": "^4.0.1",
111112
"stylelint-use-logical-spec": "4.1.0",
112113
"through2": "4.0.2",
113114
"tiny-glob": "0.2.9",

src/vendor/wordpress/styles/_utilities.scss

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,10 +19,6 @@
1919

2020
/// Wide alignment should max out at our default container width.
2121
.alignwide {
22-
// False positive linting error because SCSS lint is confusing `sass:math`'s
23-
// `max` function with the browser `max` function. May be removed once our
24-
// lint config updates to `stylelint-scss` 4.0.1 or newer.
25-
// stylelint-disable-next-line scss/no-global-function-names
2622
margin-inline: max(
2723
-50vw + 50%,
2824
math.div(size.$max-width-spread - size.$max-width-prose, -2)

0 commit comments

Comments
 (0)