Skip to content

Commit da3c096

Browse files
authored
Fix useEffect() in sky nav (#1918)
1 parent 4e8ef04 commit da3c096

File tree

14 files changed

+16
-1656
lines changed

14 files changed

+16
-1656
lines changed

src/components/sky-nav/sky-nav.stories.mdx

Lines changed: 16 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,17 @@ embedded examples.
1717
<Meta
1818
title="Components/Sky Nav"
1919
parameters={{ docs: { inlineStories: false } }}
20+
decorators={[
21+
(story) => {
22+
useEffect(() => {
23+
const { destroy } = initSkyNav(
24+
document.querySelector('.js-sky-nav-menu-toggle')
25+
);
26+
return destroy;
27+
}, []);
28+
return story();
29+
},
30+
]}
2031
/>
2132

2233
# Sky Nav
@@ -48,18 +59,10 @@ The Sky Nav is intended for use with our [our dark theme](/docs/design-themes--d
4859
},
4960
}}
5061
>
51-
{() => {
52-
useEffect(() => {
53-
const { destroy } = initSkyNav(
54-
document.querySelector('.js-sky-nav-menu-toggle')
55-
);
56-
return destroy;
57-
}, []);
58-
return template({
59-
class: 't-dark',
60-
...basicStoryArgs,
61-
});
62-
}}
62+
{template({
63+
class: 't-dark',
64+
...basicStoryArgs,
65+
})}
6366
</Story>
6467
</Canvas>
6568

@@ -82,15 +85,7 @@ But it works without a theme, too, just in case:
8285
},
8386
}}
8487
>
85-
{() => {
86-
useEffect(() => {
87-
const { destroy } = initSkyNav(
88-
document.querySelector('.js-sky-nav-menu-toggle')
89-
);
90-
return destroy;
91-
}, []);
92-
return template(basicStoryArgs);
93-
}}
88+
{template(basicStoryArgs)}
9489
</Story>
9590
</Canvas>
9691

src/prototypes/single-article/example/example.twig

Lines changed: 0 additions & 293 deletions
This file was deleted.

src/prototypes/single-article/single-article.stories.js

Lines changed: 0 additions & 43 deletions
This file was deleted.

0 commit comments

Comments
 (0)