Skip to content

Commit e5af776

Browse files
Use aria-hidden for Pagination component ellipsis (#1983)
1 parent b09a659 commit e5af776

File tree

2 files changed

+27
-9
lines changed

2 files changed

+27
-9
lines changed

.changeset/spotty-owls-pay.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@cloudfour/patterns': minor
3+
---
4+
5+
Add aria-hidden to Pagination component ellipsis

src/components/pagination/pagination.twig

Lines changed: 22 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -5,34 +5,47 @@
55
<{{ label_tag_name }} id="{{ label_id }}" class="u-hidden-visually">Pagination</{{ label_tag_name }}>
66
<ul class="c-pagination__items" role="list">
77
{% for page in pagination.pages %}
8-
<li class="c-pagination__item">
9-
{% if page.current %}
8+
{% if page.current %}
9+
<li class="c-pagination__item">
1010
<a class="c-pagination__action" href="{{ page.link }}" aria-current="page">
1111
<span class="u-hidden-visually">Page</span>
1212
<span class="c-pagination__number">{{ page.title }}</span>
1313
</a>
14-
{% elseif page.link and page.link == pagination.prev.link %}
14+
</li>
15+
{% elseif page.link and page.link == pagination.prev.link %}
16+
<li class="c-pagination__item">
1517
<a class="c-pagination__action is-previous" href="{{ page.link }}">
1618
<span class="u-hidden-visually">Previous: Page</span>
1719
<span class="c-pagination__number">{{ page.title }}</span>
1820
</a>
19-
{% elseif page.link and page.link == pagination.next.link %}
21+
</li>
22+
{% elseif page.link and page.link == pagination.next.link %}
23+
<li class="c-pagination__item">
2024
<a class="c-pagination__action is-next" href="{{ page.link }}">
2125
<span class="u-hidden-visually">Next: Page</span>
2226
<span class="c-pagination__number">{{ page.title }}</span>
2327
</a>
24-
{% elseif page.link %}
28+
</li>
29+
{% elseif page.link %}
30+
<li class="c-pagination__item">
2531
<a class="c-pagination__action" href="{{ page.link }}">
2632
<span class="u-hidden-visually">Page</span>
2733
<span class="c-pagination__number">{{ page.title }}</span>
2834
</a>
29-
{% else %}
30-
{# Fallback for non-link pages like ellipsis gaps for first/last pages #}
35+
</li>
36+
{% else %}
37+
{# Fallback for non-link pages like ellipsis gaps for first/last pages #}
38+
<li
39+
class="c-pagination__item"
40+
{% if page.title == '&hellip;' or page.title == '' %}
41+
aria-hidden="true"
42+
{% endif %}
43+
>
3144
<span class="c-pagination__action">
3245
{{ page.title }}
3346
</span>
34-
{% endif %}
35-
</li>
47+
</li>
48+
{% endif %}
3649
{% endfor %}
3750
</ul>
3851
</nav>

0 commit comments

Comments
 (0)