Skip to content

Commit d2b42ce

Browse files
committed
feat: Handle TODOs for dynamoDB
1 parent efe4001 commit d2b42ce

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/services/dynamodb/connections.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ export default ({
2929
} = dynamoDbTable
3030

3131
/**
32-
* Find MKS
32+
* Find KMS
3333
* related to this dynamo db table
3434
*/
3535
const kmsMasterKeyArn = sseDescription?.KMSMasterKeyArn
@@ -54,13 +54,13 @@ export default ({
5454
* Find IAM Roles
5555
* related to this dynamo db table
5656
*/
57-
const rolesArn: string[] = []
57+
const roleArns: string[] = []
5858
replicas?.map(({ AutoScaling: autoScaling }) => {
59-
rolesArn.push(
59+
roleArns.push(
6060
autoScaling?.ReplicaProvisionedReadCapacityAutoScalingSettings
6161
?.AutoScalingRoleArn
6262
)
63-
rolesArn.push(
63+
roleArns.push(
6464
autoScaling?.ReplicaProvisionedWriteCapacityAutoScalingSettings
6565
?.AutoScalingRoleArn
6666
)
@@ -70,7 +70,7 @@ export default ({
7070
data.find(({ name }) => name === services.iamRole)
7171
if (roles?.data?.[globalRegionName]) {
7272
const dataAtRegion: RawAwsIamRole[] = roles.data[globalRegionName].filter(
73-
({ Arn }: RawAwsIamRole) => rolesArn?.includes(Arn)
73+
({ Arn }: RawAwsIamRole) => roleArns?.includes(Arn)
7474
)
7575
if (!isEmpty(dataAtRegion)) {
7676
for (const iamRole of dataAtRegion) {

src/types/generated.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1286,7 +1286,6 @@ export type AwsDynamoDbTable = AwsBaseService & {
12861286
globalIndexes?: Maybe<Array<Maybe<AwsDynamoDbTableGlobalSecondaryIndexDescription>>>;
12871287
globalTableVersion?: Maybe<Scalars['String']>;
12881288
iamRoles?: Maybe<Array<Maybe<AwsIamRole>>>;
1289-
id: Scalars['String'];
12901289
itemCount?: Maybe<Scalars['Int']>;
12911290
keySchema?: Maybe<Array<Maybe<AwsDynamoDbTableIndexKeySchema>>>;
12921291
kms?: Maybe<Array<Maybe<AwsKms>>>;

0 commit comments

Comments
 (0)