Skip to content

Commit a95e400

Browse files
author
Cloud Xiao
committed
Fixed bug [Issue 13]
1 parent 3eedc50 commit a95e400

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/redux/reducers/issueReducer.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@ export default function issueReducer(state = initialState.issues, action) {
77
return [...state, { ...action.issue }];
88
case types.EDIT_ISSUE_SUCCESS:
99
return state.map(issue =>
10-
issue.number === action.issue.number ? action.issue : issue
10+
issue.id === action.issue.id ? action.issue : issue
1111
);
1212
case types.CLOSE_ISSUE_OPTIMISTIC:
13-
return state.filter(issue => issue.number !== action.issue.number);
13+
return state.filter(issue => issue.id !== action.issue.id);
1414
case types.LOAD_ISSUES_SUCCESS:
1515
return action.issues;
1616
default:

src/redux/reducers/issueReducer.test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,21 @@ it("removes issue when passed CLOSE_ISSUE_OPTIMISTIC", () => {
66
const initialState = [
77
{
88
title: "Issue 1",
9-
number: 1
9+
id: 1
1010
},
1111
{
1212
title: "Issue 2",
13-
number: 2
13+
id: 2
1414
},
1515
{
1616
title: "Issue 3",
17-
number: 3
17+
id: 3
1818
}
1919
];
2020

2121
const closedIssue = {
2222
title: "Issue 2",
23-
number: 2
23+
id: 2
2424
};
2525

2626
const action = actions.closeIssueOptimistic(closedIssue);

0 commit comments

Comments
 (0)